Page MenuHome

[COMPOSITOR] OCIO color spaces conversion node + 1D_3D_LUT node
Needs RevisionPublic

Authored by Cédric PAILLE (cedricp) on Sep 16 2021, 5:21 PM.

Details

Summary

Add two nodes in the compositor editor :

ColorSpace :

Convert colorspaces from/to OCIO configs

LUT:

Apply 3D/1D LUT (cube format) to an image

Diff Detail

Event Timeline

Cédric PAILLE (cedricp) requested review of this revision.Sep 16 2021, 5:21 PM
Cédric PAILLE (cedricp) created this revision.
Aaron Carlisle (Blendify) requested changes to this revision.Sep 29 2021, 6:39 AM

Can you remove the Color Space node changes as you already have submitted D12481: Compositing Convert color space node.

Could you also update this patch the reflect the changes in master?

Notible changes, node_composite_3dLut.c needs to be migrated to c++.
There is a new API for declaring node sockets, see examples of NodeDeclarationBuilder

This revision now requires changes to proceed.Sep 29 2021, 6:39 AM
Cédric PAILLE (cedricp) updated this revision to Diff 42878.EditedOct 4 2021, 10:24 AM

Updated for current master branch. This patch also contains diff D12481

Switch to cpp registration method

Manuel Castilla (manzanilla) requested changes to this revision.Oct 29 2021, 12:50 AM

Thanks for working on this, I think these nodes can be very useful.
There has been style changes in compositor (mostly naming convention), I've updated the diff to reflect the changes because it's my fault, sorry for the hassle.
Please continue from this diff:

  • Can you split it in two patches as before, please? One per node. Patches should have only one feature.

I assume this patch is for the 3dLut node:

  • Please explain briefly in the description what is a Lut and what the node can be used for. It's for users and the commit message.
  • I get this warning:
bf/blender/source/blender/compositor/operations/COM_Color3dLutOperation.cc:72:5: warning: do not use 'else' after 'continue' [readability-else-after-return]
    else if (sscanf(line, "TITLE%*[ \t]%[^\n]", title) == 1) {
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  • Will comment further once the patch is updated.

Note: You can manage patches with arcanist -> https://wiki.blender.org/wiki/Tools/CodeReview#Use_Arcanist

Hi,
Unfortunately, I have limited time to spend on this, it was mainly for color grading tests. As soon as I have a moment I'll try to do that. Note that splitting the patch is a time expensive job.

Aaron Carlisle (Blendify) requested changes to this revision.Feb 9 2022, 9:33 PM

Patch needs to be updated with master.

This revision now requires changes to proceed.Feb 9 2022, 9:33 PM