Details

Reviewers

Hans Goudey (HooglyBoogly)

Commits

rB1fb364491bad: Geometry Nodes: Set Spline Type Node Field Update

Summary

Update the Set Spline Type node for a fields based selection input.

Diff Detail

Repository: rB Blender

Event Timeline

Johnny Matthews (guitargeek) requested review of this revision.Sep 16 2021, 6:16 PM

Johnny Matthews (guitargeek) created this revision.

Johnny Matthews (guitargeek) added inline comments.Sep 16 2021, 10:22 PM

source/blender/nodes/geometry/nodes/legacy/node_geo_curve_spline_type.cc
44–45	Use Legacy DNA type

Hans Goudey (HooglyBoogly) added inline comments.Sep 16 2021, 10:29 PM

source/blender/makesdna/DNA_node_types.h
1395	If the new node uses the same fields in DNA, I don't think there's any need to add a new struct. I doubt this node will change that much in the near future anyway.
source/blender/makesrna/intern/rna_nodetree.c
9511	Same comment here actually, I think this could be shared.

Revert to use the same DNA type

Add field indicators in declaration

Hans Goudey (HooglyBoogly) accepted this revision.Sep 30 2021, 10:46 PM

This revision is now accepted and ready to land.Sep 30 2021, 10:46 PM

Updated with modify_geometry_sets

Hans Goudey (HooglyBoogly) accepted this revision.Oct 1 2021, 6:37 PM

Hans Goudey (HooglyBoogly) added inline comments.

source/blender/nodes/geometry/nodes/legacy/node_geo_curve_spline_type.cc
302	Looks like this removes the newline at the end of the file.
source/blender/nodes/geometry/nodes/node_geo_curve_spline_type.cc
288	This can use `std::move(geometry_set)`

Closed by commit rB1fb364491bad: Geometry Nodes: Set Spline Type Node Field Update (authored by Johnny Matthews (guitargeek)). · Explain WhyOct 1 2021, 7:01 PM

This revision was automatically updated to reflect the committed changes.

Johnny Matthews (guitargeek) added a commit: rB1fb364491bad: Geometry Nodes: Set Spline Type Node Field Update.

Johnny Matthews (guitargeek) added a project: Geometry Nodes.Oct 1 2021, 7:02 PM

Geometry Nodes: Update Set Spline Type Node for Fields
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 41919

release/scripts/startup/nodeitems_builtins.py

source/blender/blenkernel/BKE_node.h

source/blender/blenkernel/intern/node.cc

source/blender/makesdna/DNA_node_types.h

source/blender/makesrna/intern/rna_nodetree.c

source/blender/nodes/CMakeLists.txt

source/blender/nodes/NOD_geometry.h

source/blender/nodes/NOD_static_types.h

source/blender/nodes/geometry/nodes/legacy/node_geo_curve_spline_type.cc

source/blender/nodes/geometry/nodes/node_geo_curve_spline_type.cc

Geometry Nodes: Update Set Spline Type Node for FieldsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 41919

release/scripts/startup/nodeitems_builtins.py

source/blender/blenkernel/BKE_node.h

source/blender/blenkernel/intern/node.cc

source/blender/makesdna/DNA_node_types.h

source/blender/makesrna/intern/rna_nodetree.c

source/blender/nodes/CMakeLists.txt

source/blender/nodes/NOD_geometry.h

source/blender/nodes/NOD_static_types.h

source/blender/nodes/geometry/nodes/legacy/node_geo_curve_spline_type.cc

source/blender/nodes/geometry/nodes/node_geo_curve_spline_type.cc

Geometry Nodes: Update Set Spline Type Node for Fields
ClosedPublic
Actions

Revision Contents
Changeset List