Page MenuHome
Differential D12526

Geometry Nodes: Create New Version of Curve Set Handles Node
ClosedPublic
Actions

Authored by Johnny Matthews (guitargeek) on Sep 16 2021, 8:53 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Commits
rB1476d3587045: Geometry Nodes: Set Handle Type Node Field Update
Summary

Create a new fields-aware version of the "Set Curve Handles" node.

Diff Detail

Event Timeline

Johnny Matthews (guitargeek) requested review of this revision.Sep 16 2021, 8:53 PM
Johnny Matthews (guitargeek) created this revision.
Johnny Matthews (guitargeek) updated this revision to Diff 41939.Sep 16 2021, 10:17 PM

Update Legacy Node to use a Legacy DNA type

Johnny Matthews (guitargeek) updated this revision to Diff 41948.Sep 16 2021, 10:49 PM

Share the same RNA/DNA

Hans Goudey (HooglyBoogly) accepted this revision.Sep 24 2021, 12:32 AM

The code looks good to me.

source/blender/nodes/geometry/nodes/node_geo_curve_set_handles.cc
29

Now that socket visualization is in master, this can have .supports_field(); on it.

This revision is now accepted and ready to land.Sep 24 2021, 12:32 AM
Johnny Matthews (guitargeek) updated this revision to Diff 42347.Sep 24 2021, 3:26 AM

Add supports_field()

Hans Goudey (HooglyBoogly) mentioned this in T91780: Create nodes to get/set builtin attributes.Sep 28 2021, 10:38 PM
Johnny Matthews (guitargeek) updated this revision to Diff 42766.Oct 1 2021, 7:05 AM

merge master

Johnny Matthews (guitargeek) updated this revision to Diff 42801.Oct 1 2021, 9:01 PM

Updated with modify_geometry_sets

Hans Goudey (HooglyBoogly) accepted this revision.Oct 1 2021, 9:10 PM

Just one small comment, otherwise this is good to go.

source/blender/nodes/geometry/nodes/node_geo_curve_set_handles.cc
87

has_spline_with_type has to iterate over all of the splines, so it would be a bit more simple/efficient to just use has_bezier_spline = true; after checking the spline's type below.

Closed by commit rB1476d3587045: Geometry Nodes: Set Handle Type Node Field Update (authored by Johnny Matthews (guitargeek)). · Explain WhyOct 1 2021, 9:24 PM
This revision was automatically updated to reflect the committed changes.
Johnny Matthews (guitargeek) added a commit: rB1476d3587045: Geometry Nodes: Set Handle Type Node Field Update.
Johnny Matthews (guitargeek) added a project: Geometry Nodes.Oct 1 2021, 9:25 PM

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
1 line
source/
blender/
blenkernel/
1 line
intern/
1 line
makesdna/
7 lines
makesrna/
intern/
18 lines
nodes/
1 line
1 line
3 lines
geometry/
nodes/
legacy/
144 lines
15 lines

Diff 41939

View Options

release/scripts/startup/nodeitems_builtins.py

Loading...
View Options

source/blender/blenkernel/BKE_node.h

Loading...
View Options

source/blender/blenkernel/intern/node.cc

Loading...
View Options

source/blender/makesdna/DNA_node_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_nodetree.c

Loading...
View Options

source/blender/nodes/CMakeLists.txt

Loading...
View Options

source/blender/nodes/NOD_geometry.h

Loading...
View Options

source/blender/nodes/NOD_static_types.h

Loading...
View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_curve_set_handles.cc

Loading...
View Options

source/blender/nodes/geometry/nodes/node_geo_curve_set_handles.cc

Loading...