Page MenuHome
Differential D12527

Fix T91463: Separate points makes gap on cyclic stroke
ClosedPublic
Actions

Authored by Falk David (filedescriptor) on Sep 16 2021, 9:40 PM.

Details

Reviewers
Antonio Vazquez (antoniov)
Maniphest Tasks
T91463: Grease Pencil: Separate Strokes - Selected Points Creates a Gap in the stroke
Commits
rBffb0ecb4985b: Fix T91463: Separate points makes gap on cyclic stroke
Summary

If an entire cyclic stroke was selected, calling "Separate by Points"
would leave a gap in the new object (making the new stroke non-cyclic).

The patch makes sure that if we separate by points and all points are
selected, we fall back to separate by stroke.

Diff Detail

Repository
rB Blender
Branch
T91463 (branched from master)
Build Status
Buildable 17073
Build 17073: arc lint + arc unit

Event Timeline

Falk David (filedescriptor) created this revision.Sep 16 2021, 9:40 PM
Harbormaster completed remote builds in B17073: Diff 41933.Sep 16 2021, 9:40 PM
Falk David (filedescriptor) requested review of this revision.Sep 16 2021, 9:40 PM
Falk David (filedescriptor) added a comment.Sep 16 2021, 9:42 PM

This is broken in 2.93 LTS and 2.83 LTS as well so it should be backported.

Antonio Vazquez (antoniov) accepted this revision.Sep 17 2021, 8:23 AM
This revision is now accepted and ready to land.Sep 17 2021, 8:23 AM
Thomas Dinges (dingto) added a subscriber: Thomas Dinges (dingto).Feb 1 2022, 4:29 PM

I am going over accepted, yet not commited patches atm. Can you please check and commit this Antonio? :)

Antonio Vazquez (antoniov) added a comment.Feb 1 2022, 5:55 PM

I will commit the patch

Antonio Vazquez (antoniov) added a comment.Feb 1 2022, 5:56 PM

I will commit the patch

Closed by commit rBffb0ecb4985b: Fix T91463: Separate points makes gap on cyclic stroke (authored by Falk David (filedescriptor), committed by Antonio Vazquez (antoniov)). · Explain WhyFeb 1 2022, 6:09 PM
This revision was automatically updated to reflect the committed changes.
Antonio Vazquez (antoniov) added a commit: rBffb0ecb4985b: Fix T91463: Separate points makes gap on cyclic stroke.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
gpencil/
25 lines

Diff 41933

View Options

source/blender/editors/gpencil/gpencil_edit.c

Loading...