Details

Reviewers

Hans Goudey (HooglyBoogly)

Commits

rBaae96176e8c3: Geometry Nodes: Curve Subdivide Node with Fields

Summary

Fields-aware version of the curve subdivide node. Cuts accepts an int field

Diff Detail

Repository: rB Blender

Event Timeline

Johnny Matthews (guitargeek) requested review of this revision.Sep 17 2021, 3:51 AM

Johnny Matthews (guitargeek) created this revision.

Don't rename DNA!

Add supports_field()

This looks good, the change is quite simple anyway.

The node's exec function should be nested inside of modify_geometry_sets now, so it can work on instances.

I'm accepting this since those two changes are trivial though.

I'll probably de-duplicate the code by moving it to the geometry module after your commit.

source/blender/nodes/geometry/nodes/node_geo_curve_subdivide.cc
345	This can use `get_evaluated<int>(0);` to get the `VArray` directly instead of the `GVArray_Typed`, just a bit simpler that way.

This revision is now accepted and ready to land.Sep 30 2021, 9:32 PM

Add modify_geometry_sets and other final cleanup.

Hans Goudey (HooglyBoogly) accepted this revision.Oct 1 2021, 2:56 PM

Hans Goudey (HooglyBoogly) added inline comments.

source/blender/nodes/geometry/nodes/node_geo_curve_subdivide.cc
339–342	`selection_evaluator` -> `evaluator`

Closed by commit rBaae96176e8c3: Geometry Nodes: Curve Subdivide Node with Fields (authored by Johnny Matthews (guitargeek)). · Explain WhyOct 1 2021, 4:43 PM

This revision was automatically updated to reflect the committed changes.

Johnny Matthews (guitargeek) marked an inline comment as done.

Johnny Matthews (guitargeek) added a commit: rBaae96176e8c3: Geometry Nodes: Curve Subdivide Node with Fields.

Johnny Matthews (guitargeek) added a project: Geometry Nodes.Oct 4 2021, 5:15 PM

Geometry Nodes: Fields Version of Curve Subdivide
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 42342

release/scripts/startup/nodeitems_builtins.py

source/blender/blenkernel/BKE_node.h

source/blender/blenkernel/intern/node.cc

source/blender/makesrna/intern/rna_nodetree.c

source/blender/nodes/CMakeLists.txt

source/blender/nodes/NOD_geometry.h

source/blender/nodes/NOD_static_types.h

source/blender/nodes/geometry/nodes/legacy/node_geo_curve_subdivide.cc

source/blender/nodes/geometry/nodes/node_geo_curve_subdivide.cc

Geometry Nodes: Fields Version of Curve SubdivideClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42342

release/scripts/startup/nodeitems_builtins.py

source/blender/blenkernel/BKE_node.h

source/blender/blenkernel/intern/node.cc

source/blender/makesrna/intern/rna_nodetree.c

source/blender/nodes/CMakeLists.txt

source/blender/nodes/NOD_geometry.h

source/blender/nodes/NOD_static_types.h

source/blender/nodes/geometry/nodes/legacy/node_geo_curve_subdivide.cc

source/blender/nodes/geometry/nodes/node_geo_curve_subdivide.cc

Geometry Nodes: Fields Version of Curve Subdivide
ClosedPublic
Actions

Revision Contents
Changeset List