rB8e21d528cab98 neglected to add versioning to add the new
"use_attribute" and "attribute_name_ properties to the modifier input
list. Though they are added if the modifier's interface is updated, that
doesn't happen when the file is loaded, so patch adds them manually.
Another (simpler) solution would be calling MOD_nodes_update_interface,
but I'm not sure if that's okay to do here.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- fix-geometry-nodes-attribute-input-toggle (branched from master)
- Build Status
Buildable 17175 Build 17175: arc lint + arc unit
Event Timeline
| source/blender/blenloader/intern/versioning_300.c | ||
|---|---|---|
| 1334 | Feels like this might do the wrong thing for id properties that already have the corresponding _use_attribute property. At least it will probably lead to a memory leak when IDP_AddToGroup does not add the new id property because the name exists already. I think it would be best to just skip the versioning when there already is a property with the _use_attribute suffix in the modifier. | |
Comment Actions
- Merge branch 'master' into fix-geometry-nodes-attribute-input-toggle
- Add a check to make sure the versioning hasn't already run
| source/blender/blenloader/intern/versioning_300.c | ||
|---|---|---|
| 1347 | You shouldn't return out of this function. | |
| source/blender/blenloader/intern/versioning_300.c | ||
|---|---|---|
| 1347 | Oof, yikes, sorry about that. | |
Comment Actions
- Merge branch 'master' into fix-geometry-nodes-attribute-input-toggle
- Split the versioning to a separate function
| source/blender/blenloader/intern/versioning_300.c | ||
|---|---|---|
| 1334 | Make sure you don't mix up subversion numbers. 25 has been used above already. | |