Fix T91461: Pose Library name filter not working
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Sep 17 2021, 3:50 PM.

Details

Reviewers

Julian Eisel (Severin)

Maniphest Tasks

T91461: 3D Panel Pose Library filter doesn't appear to be working correctly.

Commits

rBa229a9dd6482: Fix T91461: Pose Library name filter not working

Summary

since AssetHandle does not have a name_property
(RNA_def_struct_name_property), and the UIList is just using the
default uilist_filter_items_default it simply cannot filter on names
(RNA_struct_name_get_alloc wont succeed).

Adding a name_property also wont work since AssetHandle inherits
PropertyGroup (which already sets name_property).

So this adds a (temporary) hack exception for RNA_AssetHandle in
uilist_filter_items_default until the design of AssetHandle progresses
further.

thx @Julian Eisel (Severin) for additional feedback

Diff Detail

Repository

rB Blender

Branch

T91461 (branched from master)

Build Status

Buildable 17101
Build 17101: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Sep 17 2021, 3:50 PM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B17099: Diff 41989.Sep 17 2021, 3:50 PM

Philipp Oeser (lichtwerk) added a project: User Interface.Sep 17 2021, 3:51 PM

Julian Eisel (Severin) requested changes to this revision.Sep 17 2021, 4:22 PM

Julian Eisel (Severin) added inline comments.

source/blender/editors/interface/interface_template_list.cc
223	Suggest: /* XXX The AssetHandle design is hacky and meant to be temporary. It can't have a proper name property, so for now this hardcoded exception is needed. */
226	If you just use `BLI_strdup()` there's no need for the `free_namebuf`, it'll just always be an allocated string. Besides that, and this is an actual bug, `sizeof(asset_name)` will always return the size of a pointer, so this will break for strings longer than 8 bytes (on 64bit machines that is).