Page MenuHome
Differential D12562

Smooth contour modifier
Needs ReviewPublic
Actions

Authored by YimingWu (NicksBest) on Sep 19 2021, 9:22 AM.

Details

Reviewers
Sebastian Parborg (zeddb)
Group Reviewers
Modifiers
Maniphest Tasks
T91515: Smooth contour modifier for better feature line generation.
Summary

The smooth contour modifier clears the ambiguity in contour visibility so that edges could be chained fluently.

The author is @Sebastian Parborg (zeddb) .

Here's the before/after image of this modifier applied on mesh before generating line art.

I modified a bit so mesh manipulation is enabled by default.

Diff Detail

Repository
rB Blender

Event Timeline

YimingWu (NicksBest) requested review of this revision.Sep 19 2021, 9:22 AM
YimingWu (NicksBest) created this revision.
YimingWu (NicksBest) edited the summary of this revision. (Show Details)
YimingWu (NicksBest) added a task: T91515: Smooth contour modifier for better feature line generation..
Aleš Jelovčan (frogstomp) added a subscriber: Aleš Jelovčan (frogstomp).EditedSep 19 2021, 12:55 PM

applied against current master 257c7753e9beb2cbd34936766d5fc6c4dc441778
getting this error on build:

  bf_blenkernel.vcxproj -> ..\build_windows_x64_vc16_Release\lib\Release\bf_blenkernel.lib

Build FAILED.

..\lib\win64_vc15\usd\include\pxr/usd/usdGeom/xformOp.h(86,1): warning C4003: not enough arguments for function-like macro invocation 'BOOST_VMD_IS_TUPLE' (compiling source file ..\blender\source\blender\io\usd\intern\usd_reader_mesh.cc) [..\build_windows_x64_vc16_Release\source\blender\io\usd\bf_usd.vcxproj]
..\lib\win64_vc15\usd\include\pxr/usd/usdGeom/xformOp.h(86,1): warning C4003: not enough arguments for function-like macro invocation 'BOOST_VMD_DETAIL_IS_TUPLE' (compiling source file ..\blender\source\blender\io\usd\intern\usd_reader_mesh.cc) [..\build_windows_x64_vc16_Release\source\blender\io\usd\bf_usd.vcxproj]
..\lib\win64_vc15\usd\include\pxr/usd/usdGeom/xformOp.h(86,1): warning C4003: not enough arguments for function-like macro invocation 'BOOST_VMD_DETAIL_PARENS_SPLIT' (compiling source file ..\blender\source\blender\io\usd\intern\usd_reader_mesh.cc) [..\build_windows_x64_vc16_Release\source\blender\io\usd\bf_usd.vcxproj]
..\lib\win64_vc15\usd\include\pxr/usd/usdGeom/xformOp.h(86,1): warning C4003: not enough arguments for function-like macro invocation 'BOOST_PP_SEQ_DETAIL_IS_NOT_EMPTY' (compiling source file ..\blender\source\blender\io\usd\intern\usd_reader_mesh.cc) [..\build_windows_x64_vc16_Release\source\blender\io\usd\bf_usd.vcxproj]
..\lib\win64_vc15\usd\include\pxr/usd/usdGeom/xformOp.h(86,1): warning C4003: not enough arguments for function-like macro invocation 'BOOST_PP_SEQ_DETAIL_EMPTY_SIZE' (compiling source file ..\blender\source\blender\io\usd\intern\usd_reader_mesh.cc) [..\build_windows_x64_vc16_Release\source\blender\io\usd\bf_usd.vcxproj]
..\lib\win64_vc15\usd\include\pxr/usd/usdGeom/xformOp.h(86,1): warning C4003: not enough arguments for function-like macro invocation 'BOOST_PP_TUPLE_SIZE' (compiling source file ..\blender\source\blender\io\usd\intern\usd_reader_mesh.cc) [..\build_windows_x64_vc16_Release\source\blender\io\usd\bf_usd.vcxproj]
..\blender\source\blender\modifiers\intern\MOD_smooth_contour.c(2171,21): warning C4189: 'cusp_uv': local variable is initialized but not referenced [..\build_windows_x64_vc16_Release\source\blender\modifiers\bf_modifiers.vcxproj]
..\blender\source\blender\modifiers\intern\MOD_smooth_contour.c(4824,37): error C4133: 'function': incompatible types - from 'Object **' to 'ID **' [..\build_windows_x64_vc16_Release\source\blender\modifiers\bf_modifiers.vcxproj]
    7 Warning(s)
    1 Error(s)
YimingWu (NicksBest) updated this revision to Diff 42043.Sep 19 2021, 1:23 PM

Fix MSVC error.

Aleš Jelovčan (frogstomp) added a comment.Sep 19 2021, 1:47 PM

@Sebastian Parborg (zeddb) testing, building works:

got my first crash while unticking the "b)"

steps to reproduce:

add lineart
add suzzane, subdivide x3
add smooth contour
untick "b)" -> crash

YimingWu (NicksBest) added a comment.Sep 19 2021, 2:00 PM

@Aleš Jelovčan (frogstomp) From what I gathered, just don't uncheck anything, or make sure you don't have anything checked after the first unchecked checkbox. Leave it default and you should be good.

Antonio Vazquez (antoniov) added a subscriber: Antonio Vazquez (antoniov).Sep 19 2021, 4:23 PM

@YimingWu (NicksBest) Why you have code of geometry nodes in the patch?

Henrik Dick (weasel) awarded a token.Sep 19 2021, 5:53 PM
YimingWu (NicksBest) added a comment.Sep 20 2021, 5:36 PM

I believe this is from automerging... I'll fix it.

YimingWu (NicksBest) updated this revision to Diff 42410.Sep 25 2021, 8:04 AM

Updated to latest master.

Seems that those wrong geometry node code is cleaned up.

Gavriel Lavi (Gavriel5578) awarded a token.Sep 29 2021, 11:29 AM

Revision Contents
Changeset List

PathSize
intern/
opensubdiv/
internal/
evaluator/
16 lines
10 lines
86 lines
11 lines
source/
blender/
makesdna/
7 lines
22 lines
intern/
2 lines
makesrna/
1 line
intern/
68 lines
modifiers/
1 line
1 line
intern/
4911 lines
1 line

Diff 42410

View Options

intern/opensubdiv/internal/evaluator/evaluator_capi.cc

Loading...
View Options

intern/opensubdiv/internal/evaluator/evaluator_impl.h

Loading...
View Options

intern/opensubdiv/internal/evaluator/evaluator_impl.cc

Loading...
View Options

intern/opensubdiv/opensubdiv_evaluator_capi.h

Loading...
View Options

source/blender/makesdna/DNA_modifier_defaults.h

Loading...
View Options

source/blender/makesdna/DNA_modifier_types.h

Loading...
View Options

source/blender/makesdna/intern/dna_defaults.c

Loading...
View Options

source/blender/makesrna/RNA_access.h

Loading...
View Options

source/blender/makesrna/intern/rna_modifier.c

Loading...
View Options

source/blender/modifiers/CMakeLists.txt

Loading...
View Options

source/blender/modifiers/MOD_modifiertypes.h

Loading...
View Options

source/blender/modifiers/intern/MOD_smooth_contour.c

Loading...
View Options

source/blender/modifiers/intern/MOD_util.c

Loading...