Fix T83697: Sculpt Rotate brush incorrect pen pressure behavior
AbandonedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Sep 20 2021, 2:48 PM.

Details

Reviewers

Julien Kaspar (JulienKaspar)
Campbell Barton (campbellbarton)
Jeroen Bakker (jbakker)

Maniphest Tasks

T83697: Rotate sculpting brush may have an incorrect pen pressure behavior

Summary

This is because pressure is only taken once at the very beginning of the
stroke if the stroke does not support changing radius while dragging
(see paint_supports_dynamic_size, sculpt_update_cache_variants,
sculpt_is_grab_tool).

A similar thing came up for radius (but was closed, see T56930: Brush size pressure setting broken), but I
think here (for pressure) it could actually make sense to support
sensitivity. Especially because you will never be able to get 1.0
strength when starting a stroke.

Diff Detail

Repository

rB Blender

Branch

T83697 (branched from master)

Build Status

Buildable 17148
Build 17148: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Sep 20 2021, 2:48 PM

Philipp Oeser (lichtwerk) created this revision.

Philipp Oeser (lichtwerk) added a project: Sculpt, Paint & Texture.Sep 20 2021, 2:49 PM

Harbormaster completed remote builds in B17148: Diff 42083.Sep 20 2021, 2:49 PM

@Joseph Eagar (joeedh) : do you review stuff in Sculpt, Paint & Texture ?

LGTM

This does not work in an intuitive way. With this patch, the pressure sensitivity will live update the strength of the stroke until the pen is lifted and the operation is done.
The issue is that the act of lifting up the pen will revert the pen pressure back to 0 and undo the stroke entirely. This makes the brush unusable.

There was a test with D6603 previously to incorporate the pressure sensitivity properly into anchored brushes like Grab, Rotate, Thumb, etc.
But until then we should proceed this way:

The pressure sensitivity should not be used at all for these brushes.
An extra improvement would be to remove the pressure sensitivity button from the sliders (Like with the Snake Hook brush strength)

This revision now requires changes to proceed.May 19 2022, 11:26 AM

Julien Kaspar (JulienKaspar) mentioned this in T83697: Rotate sculpting brush may have an incorrect pen pressure behavior.May 19 2022, 11:29 AM

In D12568#403116, @Julien Kaspar (JulienKaspar) wrote:

This does not work in an intuitive way. With this patch, the pressure sensitivity will live update the strength of the stroke until the pen is lifted and the operation is done.
The issue is that the act of lifting up the pen will revert the pen pressure back to 0 and undo the stroke entirely. This makes the brush unusable.

How have I not noticed this at the time of writing that patch? (cant find a reason for this... anyways, will abandon then).

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

sculpt_paint/

sculpt.c

3 lines

Diff 42083

View Options

source/blender/editors/sculpt_paint/sculpt.c

Fix T83697: Sculpt Rotate brush incorrect pen pressure behaviorAbandonedPublicActions