Page MenuHome
Differential D12569

Cleanup: Refactor VSE overlay settings
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Sep 20 2021, 2:52 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Commits
rB7cb65e45814d: Cleanup: Refactor VSE overlay settings
Summary

Move overlay flags into SequencerPreviewOverlay and
SequencerTimelineOverlay structs.

Diff Detail

Repository
rB Blender

Event Timeline

Richard Antalik (ISS) requested review of this revision.Sep 20 2021, 2:52 PM
Richard Antalik (ISS) created this revision.
Harbormaster completed remote builds in B17149: Diff 42084.Sep 20 2021, 2:52 PM
Campbell Barton (campbellbarton) accepted this revision.Sep 20 2021, 3:22 PM
This revision is now accepted and ready to land.Sep 20 2021, 3:22 PM
Campbell Barton (campbellbarton) added inline comments.Sep 20 2021, 3:26 PM
source/blender/makesdna/DNA_space_types.h
586–589

There could be a prefix to differentiate timeline and overlay:

eg: SEQ_PRV_* SEQ_TIMELINE_, so these flags aren't accidentally swapped between the wrong overlay types.

Peter Fog (tintwotin) added a subscriber: Peter Fog (tintwotin).Sep 20 2021, 3:37 PM

https://developer.blender.org/T90870

Campbell Barton (campbellbarton) added inline comments.Sep 20 2021, 4:26 PM
source/blender/makesdna/DNA_space_types.h
586–589

Checking 3D view naming, perhaps e.g. V3D_OVERLAY_EDIT_OCCLUDE_WIRE, this would be more consistent:

  • SEQ_OVERLAY_PREVIEW_*
  • SEQ_OVERLAY_TIMELINE_*
Closed by commit rB7cb65e45814d: Cleanup: Refactor VSE overlay settings (authored by Richard Antalik (ISS)). · Explain WhySep 20 2021, 4:31 PM
This revision was automatically updated to reflect the committed changes.
Richard Antalik (ISS) added a commit: rB7cb65e45814d: Cleanup: Refactor VSE overlay settings.
Richard Antalik (ISS) added inline comments.Sep 20 2021, 4:37 PM
source/blender/makesdna/DNA_space_types.h
586–589

Oops, too late, I guess it would look nicer, but these are flags of overlay struct anyway, so I thought that would be redundant.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
45 lines
source/
blender/
blenkernel/
2 lines
blenloader/
intern/
2 lines
2 lines
4 lines
53 lines
8 lines
editors/
gpencil/
2 lines
render/
2 lines
space_sequencer/
47 lines
9 lines
makesdna/
58 lines
makesrna/
intern/
208 lines

Diff 42088

View Options

release/scripts/startup/bl_ui/space_sequencer.py

Loading...
View Options

source/blender/blenkernel/BKE_blender_version.h

Loading...
View Options

source/blender/blenloader/intern/versioning_260.c

Loading...
View Options

source/blender/blenloader/intern/versioning_280.c

Loading...
View Options

source/blender/blenloader/intern/versioning_290.c

Loading...
View Options

source/blender/blenloader/intern/versioning_300.c

Loading...
View Options

source/blender/blenloader/intern/versioning_defaults.c

Loading...
View Options

source/blender/editors/gpencil/annotate_paint.c

Loading...
View Options

source/blender/editors/render/render_opengl.c

Loading...
View Options

source/blender/editors/space_sequencer/sequencer_draw.c

Loading...
View Options

source/blender/editors/space_sequencer/space_sequencer.c

Loading...
View Options

source/blender/makesdna/DNA_space_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_space.c

Loading...