Fix T91557: Texture Paint Stencil doesnt use assigned UV Layer
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Sep 21 2021, 1:14 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Julien Kaspar (JulienKaspar)
Daniel Bystedt (dbystedt)

Maniphest Tasks

T91557: Texture Paint Stencil doesn't use assigned UV Layer

Commits

rB08fe34b7fdc9: Fix T91557: Texture Paint Stencil doesnt use assigned UV Layer
rB5b588282a68e: Fix T91557: Texture Paint Stencil doesnt use assigned UV Layer
rBf11bcb5a80eb: Fix T91557: Texture Paint Stencil doesnt use assigned UV Layer

Summary

Choosing a UV layer would actually affect the overlay in the viewport
and also painting with the mask brush was in that UV space, but the
resulting stencil mask was always applied with the active UV (not the
explicitly selected stencil UV -- the one one is looking at in the
viewport!) to painting.

This has been like that as far as I have checked back (at least 2.79b),
I am surprised this has not come up before, but it does not seem to make
sense at all...

Now use the UV specified for the stencil layer when applying the mask for
painting, so it corresponds to the stencil mask one is looking at in the
viewport.

Diff Detail

Repository

rB Blender

Branch

T91557 (branched from master)

Build Status

Buildable 17185
Build 17185: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Sep 21 2021, 1:14 PM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B17185: Diff 42153.Sep 21 2021, 1:14 PM

Test file:

T91557.blend816 KBDownload

Raimund Klink (Raimund58) awarded a token.Sep 21 2021, 3:30 PM

Hello!

I checked your testfile and I could see the issue that you are pointing out. Sounds like a nice thing to fix.

Unfortunately I am unable to use arcpatch to get the patch for some reason

C:\blender-git\blender>arc patch T91557 --trace
 ARGV  "E:\users\Daniel\phabricator\arcanist\bin\..\bin\arc" patch T91557 --trace
 PCNTL  Unable to install signal handler, pcntl_signal() unavailable. Continuing without signal handling.
>>> [1] (+0) <exec> $ php -f "E:\users\Daniel\phabricator\arcanist/scripts/arcanist.php" -- patch T91557 --trace
 ARGV  "E:\users\Daniel\phabricator\arcanist/scripts/arcanist.php" patch T91557 --trace
 LOAD  Loaded "arcanist" from "E:\users\Daniel\phabricator\arcanist\src".
Config: Reading user configuration file "C:\Users\Daniel\AppData\Roaming/.arcrc"...
Config: Did not find system configuration at "C:\ProgramData\Phabricator\Arcanist\config".
Working Copy: Reading .arcconfig from "C:\blender-git\blender/.arcconfig".
Working Copy: Path "C:\blender-git\blender" is part of `git` working copy "C:\blender-git\blender".
Working Copy: Project root is at "C:\blender-git\blender".
Config: Did not find local configuration at "C:\blender-git\blender\.git\arc\config".
>>> [1] (+0) <http> https://developer.blender.org/api/differential.querydiffs
<<< [1] (+890) <http> 890,336 us
>>> [2] (+890) <http> https://developer.blender.org/api/user.whoami
<<< [2] (+981) <http> 90,506 us
>>> [3] (+981) <http> https://developer.blender.org/api/differential.querydiffs
<<< [3] (+1,072) <http> 90,808 us

[2021-09-21 22:31:09] EXCEPTION: (ConduitClientException) ERR-CONDUIT-CORE: <differential.querydiffs> Expected a numeric scalar or null for %Ld conversion. Query: revisionID IN (%Ld) at [<arcanist>\src\conduit\ConduitFuture.php:70]
arcanist(head=master, ref.master=4b3baca999a4)
  #0 ConduitFuture::didReceiveResult(array) called at [<arcanist>\src\future\FutureProxy.php:40]
  #1 FutureProxy::isReady() called at [<arcanist>\src\future\Future.php:63]
  #2 Future::updateFuture() called at [<arcanist>\src\future\FutureIterator.php:224]
  #3 FutureIterator::next() called at [<arcanist>\src\future\FutureIterator.php:190]
  #4 FutureIterator::rewind()
  #5 iterator_to_array(FutureIterator) called at [<arcanist>\src\future\FutureIterator.php:84]
  #6 FutureIterator::resolveAll() called at [<arcanist>\src\future\Future.php:47]
  #7 Future::resolve() called at [<arcanist>\src\workflow\ArcanistWorkflow.php:1385]
  #8 ArcanistWorkflow::loadBundleFromConduit(ConduitClient, array) called at [<arcanist>\src\workflow\ArcanistWorkflow.php:1376]
  #9 ArcanistWorkflow::loadRevisionBundleFromConduit(ConduitClient, string) called at [<arcanist>\src\workflow\ArcanistPatchWorkflow.php:384]
  #10 ArcanistPatchWorkflow::run() called at [<arcanist>\src\workflow\ArcanistPatchWorkflow.php:398]
  #11 ArcanistPatchWorkflow::run() called at [<arcanist>\scripts\arcanist.php:419]
<<< [1] (+1,219) <exec> 1,218,997 us

C:\blender-git\blender>