Page MenuHome
Differential D12585

Move curve to mesh node implementation to blenkernel
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Sep 21 2021, 4:37 PM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Commits
rB3642e1742844: Cleanup: Move curve to mesh node implementation to blenkernel
Summary

I would like to use this for curve object data conversion to mesh in D12533.

Diff Detail

Repository
rB Blender
Branch
curve-to-mesh-blenkernel (branched from master)
Build Status
Buildable 17196
Build 17196: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Sep 21 2021, 4:37 PM
Hans Goudey (HooglyBoogly) created this revision.
Harbormaster completed remote builds in B17196: Diff 42165.Sep 21 2021, 4:37 PM
Hans Goudey (HooglyBoogly) added a child revision: D12533: Fix/Simplify curve object to mesh conversion.Sep 21 2021, 4:57 PM
Jacques Lucke (JacquesLucke) accepted this revision.Sep 21 2021, 5:15 PM
Jacques Lucke (JacquesLucke) added inline comments.
source/blender/blenkernel/BKE_curve_to_mesh.hh
29

Comments should be next to the implementation, not in the declaration. Think we had this in the style guide at some point, couldn't find it right now.

This revision is now accepted and ready to land.Sep 21 2021, 5:15 PM
Hans Goudey (HooglyBoogly) added inline comments.Sep 21 2021, 5:30 PM
source/blender/blenkernel/BKE_curve_to_mesh.hh
29

Oh yeah, I usually do that, just forgot here, thanks.

Closed by commit rB3642e1742844: Cleanup: Move curve to mesh node implementation to blenkernel (authored by Hans Goudey (HooglyBoogly)). · Explain WhySep 21 2021, 6:57 PM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rB3642e1742844: Cleanup: Move curve to mesh node implementation to blenkernel.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
40 lines
2 lines
blenkernel/
intern/
curve_to_mesh_convert.cc/
nodes/
geometry/
nodes/
node_geo_curve_to_mesh.cc
66 lines
nodes/
geometry/
nodes/
710 lines

Diff 42165

View Options

source/blender/blenkernel/BKE_curve_to_mesh.hh

Loading...
View Options

source/blender/blenkernel/CMakeLists.txt

Loading...
View Options

source/blender/blenkernel/intern/curve_to_mesh_convert.cc

Loading...
View Options

source/blender/nodes/geometry/nodes/node_geo_curve_to_mesh.cc

Loading...