Page MenuHome
Differential D12617

Cycles: Improve handling of tile file error
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Sep 23 2021, 5:22 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rCdd4611897373: Improve handling of tile file error
rB728ae33f3720: Cycles: Improve handling of tile file error
Summary

Expose them to the interface, and stop rendering as soon as possible.

Diff Detail

Repository
rB Blender

Event Timeline

Sergey Sharybin (sergey) requested review of this revision.Sep 23 2021, 5:22 PM
Sergey Sharybin (sergey) created this revision.
Harbormaster completed remote builds in B17272: Diff 42314.Sep 23 2021, 5:22 PM
Brecht Van Lommel (brecht) requested changes to this revision.Sep 27 2021, 4:32 PM

Seems fine overall, just nitpicking about the naming.

intern/cycles/blender/blender_session.h
153

This name is a bit confusing to me. I suggest check_and_report_session_error().

This revision now requires changes to proceed.Sep 27 2021, 4:32 PM
Sergey Sharybin (sergey) updated this revision to Diff 42534.Sep 28 2021, 10:25 AM

Follow Brecht's naming suggestion.

Harbormaster completed remote builds in B17364: Diff 42534.Sep 28 2021, 10:25 AM
Brecht Van Lommel (brecht) accepted this revision.Sep 28 2021, 2:13 PM
This revision is now accepted and ready to land.Sep 28 2021, 2:13 PM
Closed by commit rB728ae33f3720: Cycles: Improve handling of tile file error (authored by Sergey Sharybin (sergey)). · Explain WhySep 28 2021, 5:02 PM
This revision was automatically updated to reflect the committed changes.
Sergey Sharybin (sergey) added a commit: rB728ae33f3720: Cycles: Improve handling of tile file error.
Brecht Van Lommel (brecht) added a commit: rCdd4611897373: Improve handling of tile file error.Jan 27 2022, 11:28 PM

Revision Contents
Changeset List

PathSize
intern/
cycles/
blender/
5 lines
39 lines
integrator/
11 lines
render/
8 lines

Diff 42568

View Options

intern/cycles/blender/blender_session.h

Loading...
View Options

intern/cycles/blender/blender_session.cpp

Loading...
View Options

intern/cycles/integrator/path_trace.cpp

Loading...
View Options

intern/cycles/render/tile.cpp

Loading...