Page MenuHome
Differential D12631

UI: swap tool and regular header
ClosedPublic
Actions

Authored by Campbell Barton (campbellbarton) on Sep 25 2021, 6:12 AM.

Details

Reviewers
Julian Eisel (Severin)
Pablo Vazquez (pablovazquez)
Francesco Siddi (fsiddi)
Summary

Swap the tool-header and header order so the tool-header
so the header is always on the window edge.

See design task: T91536.

NOTE: files saved in 3.0 will have overlapping headers when opened in any version of Blender before this commit.

Notes:

  • The tool-header labels are harder to read over transparent backdrop.

  • The visual separation between the tools name and labels for tool settings aren't always so obvious.

Diff Detail

Repository
rB Blender
Branch
TEMP-HEADER-SWAP (branched from master)
Build Status
Buildable 17359
Build 17359: arc lint + arc unit

Event Timeline

Campbell Barton (campbellbarton) requested review of this revision.Sep 25 2021, 6:12 AM
Campbell Barton (campbellbarton) created this revision.
Harbormaster completed remote builds in B17307: Diff 42409.Sep 25 2021, 6:12 AM
Campbell Barton (campbellbarton) mentioned this in T91536: Swap Tool Settings and Headers in Editors.Sep 25 2021, 6:13 AM
RedMser (RedMser) added a subscriber: RedMser (RedMser).Sep 25 2021, 10:33 AM
Campbell Barton (campbellbarton) updated this revision to Diff 42526.Sep 28 2021, 6:47 AM
Harbormaster completed remote builds in B17359: Diff 42526.Sep 28 2021, 6:47 AM
Campbell Barton (campbellbarton) retitled this revision from Swap headers (WIP) to UI: swap tool and regular header.Sep 28 2021, 6:52 AM
Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)
Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Sep 28 2021, 7:00 AM
Campbell Barton (campbellbarton) added reviewers: Julian Eisel (Severin), Pablo Vazquez (pablovazquez), Francesco Siddi (fsiddi).
Campbell Barton (campbellbarton) added a project: User Interface.
Francesco Siddi (fsiddi) accepted this revision.Sep 28 2021, 2:52 PM

Looks ok, thank you! Pablo will work further to ensure a basic level or readability on the theme level.

This revision is now accepted and ready to land.Sep 28 2021, 2:52 PM
Julian Eisel (Severin) accepted this revision.Sep 29 2021, 10:49 AM

For me this seems like an improvement. There's a more logical flow in the UI with it.

source/blender/blenloader/intern/versioning_300.c
1524–1547

Would be good to explain in a comment why this is needed. It's not clear at all without the context of the full patch.

Campbell Barton (campbellbarton) updated this revision to Diff 42632.Sep 29 2021, 11:57 AM
  • Rebase on master, add comment
Harbormaster completed remote builds in B17416: Diff 42632.Sep 29 2021, 11:57 AM
Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Sep 29 2021, 11:59 AM
Campbell Barton (campbellbarton) closed this revision.Sep 29 2021, 12:04 PM
Campbell Barton (campbellbarton) mentioned this in rB4cf4bb2664eb: UI: swap tool and regular header.Sep 29 2021, 12:04 PM

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
12 lines
5 lines
11 lines
12 lines
source/
blender/
blenloader/
intern/
26 lines
editors/
screen/
4 lines
space_image/
14 lines
space_sequencer/
14 lines
space_view3d/
14 lines

Diff 42526

View Options

release/scripts/startup/bl_ui/space_image.py

Loading...
View Options

release/scripts/startup/bl_ui/space_sequencer.py

Loading...
View Options

release/scripts/startup/bl_ui/space_toolsystem_common.py

Loading...
View Options

release/scripts/startup/bl_ui/space_view3d.py

Loading...
View Options

source/blender/blenloader/intern/versioning_300.c

Loading...
View Options

source/blender/editors/screen/area.c

Loading...
View Options

source/blender/editors/space_image/space_image.c

Loading...
View Options

source/blender/editors/space_sequencer/space_sequencer.c

Loading...
View Options

source/blender/editors/space_view3d/space_view3d.c

Loading...