Differential D12638
Geometry Nodes: Fields Version of Raycast Node Authored by Hans Goudey (HooglyBoogly) on Sep 25 2021, 10:21 PM.
Details This patch includes an updated version of the raycast node that uses fields   The source position replaces the input geometry (since this node is Thanks to @Johnny Matthews (guitargeek) for an initial version of this patch! Test Files:
Diff Detail
Event TimelineComment Actions Added "Source Position" to signature Still crashing: Stack trace: ucrtbased.dll!issue_debug_notification(const wchar_t * const message) Line 28 at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(28) ucrtbased.dll!__acrt_report_runtime_error(const wchar_t * message) Line 154 at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(154) ucrtbased.dll!abort() Line 61 at minkernel\crts\ucrt\src\appcrt\startup\abort.cpp(61) blender.exe!_BLI_assert_abort() Line 62 at C:\blender-git\blender\source\blender\blenlib\intern\BLI_assert.c(62) blender.exe!blender::Span<blender::fn::GField>::operator[](__int64 index) Line 247 at C:\blender-git\blender\source\blender\blenlib\BLI_span.hh(247) blender.exe!blender::fn::build_multi_function_procedure_for_fields(blender::fn::MFProcedure & procedure, blender::ResourceScope & scope, const blender::fn::FieldTreeInfo & field_tree_info, blender::Span<blender::fn::GFieldRef> output_fields) Line 204 at C:\blender-git\blender\source\blender\functions\intern\field.cc(204) blender.exe!blender::fn::evaluate_fields(blender::ResourceScope & scope, blender::Span<blender::fn::GFieldRef> fields_to_evaluate, blender::IndexMask mask, const blender::fn::FieldContext & context, blender::Span<blender::fn::GVMutableArray *> dst_varrays) Line 363 at C:\blender-git\blender\source\blender\functions\intern\field.cc(363) blender.exe!blender::fn::FieldEvaluator::evaluate() Line 665 at C:\blender-git\blender\source\blender\functions\intern\field.cc(665) blender.exe!blender::nodes::set_position_in_component(GeometryComponent & component, const blender::fn::Field<bool> & selection_field, const blender::fn::Field<blender::float3> & position_field) Line 48 at C:\blender-git\blender\source\blender\nodes\geometry\nodes\node_geo_set_position.cc(48) blender.exe!blender::nodes::geo_node_set_position_exec(blender::nodes::GeoNodeExecParams params) Line 65 at C:\blender-git\blender\source\blender\nodes\geometry\nodes\node_geo_set_position.cc(65) blender.exe!blender::modifiers::geometry_nodes::GeometryNodesEvaluator::execute_geometry_node(const blender::nodes::DNode node, blender::modifiers::geometry_nodes::NodeState & node_state) Line 891 at C:\blender-git\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc(891) blender.exe!blender::modifiers::geometry_nodes::GeometryNodesEvaluator::execute_node(const blender::nodes::DNode node, blender::modifiers::geometry_nodes::NodeState & node_state) Line 865 at C:\blender-git\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc(865) blender.exe!blender::modifiers::geometry_nodes::GeometryNodesEvaluator::node_task_run(const blender::nodes::DNode node, blender::modifiers::geometry_nodes::NodeState & node_state) Line 692 at C:\blender-git\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc(692) blender.exe!blender::modifiers::geometry_nodes::GeometryNodesEvaluator::run_node_from_task_pool(TaskPool * task_pool, void * task_data) Line 674 at C:\blender-git\blender\source\blender\modifiers\intern\MOD_nodes_evaluator.cc(674) blender.exe!Task::operator()() Line 179 at C:\blender-git\blender\source\blender\blenlib\intern\task_pool.cc(179) blender.exe!tbb::internal::function_task<Task>::execute() Line 1060 at C:\blender-git\lib\win64_vc15\tbb\include\tbb\task.h(1060) [External Code] Connect the circled link in this file
Comment Actions
I'm running into an issue where the virtual arrays retrieved from the evaluator in the multi-function Comment Actions
Didn't look at it in detail, but it may be valid that they don't have the same size if they are long enough (mask.min_array_size). Comment Actions
Yeah, it turns out it was just that issue, but in multiple places.  By the way, the result issue is a pretty ugly performance issue that we might have Comment Actions Is this patch still WIP? Yes, I think we can be a bit smarter about not evaluating the node multiple times in the future. Comment Actions
Comment Actions
| ||||||||||||||||||
