Page MenuHome

Fix T91160 - Movie Clip Editor - frame indicator/controller is not displayed
ClosedPublic

Authored by Aidan Davey (ShadowDragon) on Sep 28 2021, 9:36 AM.

Details

Summary

The frame indicator/controller is not displayed when in the Graph or Dopesheet view of the Movie Clip Editor

To solve this we could call the function ED_time_scrub_draw_current_frame in clip_draw_dopesheet_main and graph_region_draw in space_clip.c

Diff Detail

Repository
rB Blender

Event Timeline

Aidan Davey (ShadowDragon) requested review of this revision.Sep 28 2021, 9:36 AM
Aidan Davey (ShadowDragon) created this revision.

Thx!

hint: https://wiki.blender.org/wiki/Style_Guide/Commit_Messages

Start the commit log with "Fix T12345: " or "Fix:" (for unreported bugs), so it's immediately clear that it's a bugfix.
Bonus Feature: mentioning "Fix T12345" will autoclose the bug T12345 on developer.blender.org!

I think this will also link the Differential with the task/bugreport automatically then (at least it does when you use Arcanist

Aidan Davey (ShadowDragon) retitled this revision from To Address T91160 - Movie Clip Editor - frame indicator/controller is not displayed to Fix T91160 - Movie Clip Editor - frame indicator/controller is not displayed.Sep 28 2021, 9:53 AM

Talked to Jeroen, seems it is more of his area.

I couldn't reproduce the issue myself, which suggests it might be something to do with the GL state other than a missing drawing call. Something like that. Jeroen will pick it up from here :)

Jeroen Bakker (jbakker) requested changes to this revision.Oct 27 2021, 8:57 AM

Was able to reproduce and this patch fixes the issue.

vs

Patch does not apply to latest master. There was an API change on ED_time_scrub_draw_current_frameIIRC. Are you available to do the needed changes?

source/blender/editors/space_clip/space_clip.c
1083

ED_time_scrub_draw_current_frame(region, scene, sc->flag & SC_SHOW_SECONDS);

1133

ED_time_scrub_draw_current_frame(region, scene, sc->flag & SC_SHOW_SECONDS);

This revision now requires changes to proceed.Oct 27 2021, 8:57 AM

Yes I'm available and happy to work on this later today,

Updated to take into account an API change on ED_time_scrub_draw_current_frame

All is fine now. Do you have commit access?

This revision is now accepted and ready to land.Oct 29 2021, 8:34 AM

He does not, you can check by clicking the profile and check if they belong to the bf comitters project.

Aidan Davey (ShadowDragon) marked 2 inline comments as done.Oct 31 2021, 4:02 PM

No I don't have commit access. Could anyone else take this forward please?

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Jan 4 2022, 8:20 AM
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)