Paths

Table of Contentst

Differential D12679

Geometry Nodes: Translate Instances node
ClosedPublic
Actions

Authored by Erik Abrahamsson (erik85) on Sep 28 2021, 8:17 PM.

Tags

Subscribers

Andy Cuccaro (AndyCuccaro)

Tokens

"Love" token, awarded by Rusculleda.

Details

Reviewers

Hans Goudey (HooglyBoogly)
Jacques Lucke (JacquesLucke)

Maniphest Tasks

T91655: Translate Instances node

Commits

rB9d49fc2ba0ec: Geometry Nodes: Translate Instances Node

Summary

Adds a node that can translate instances in global or local space.
Task T91655

Diff Detail

Repository

Branch

arcpatch-D12679 (branched from master)

Build Status

Buildable 17779
Build 17779: arc lint + arc unit

Event Timeline

Erik Abrahamsson (erik85) requested review of this revision.Sep 28 2021, 8:17 PM

Erik Abrahamsson (erik85) created this revision.

Andy Cuccaro (AndyCuccaro) added a subscriber: Andy Cuccaro (AndyCuccaro).Sep 29 2021, 1:17 AM

Hans Goudey (HooglyBoogly) added a task: T91655: Translate Instances node.Oct 11 2021, 11:39 PM

Nice work!

source/blender/nodes/geometry/nodes/node_geo_translate_instances.cc

How about this? It's a bit nicer looking IMO:

if (local_space) {
  const float4x4 loc_matrix = float4x4::from_location(translation);
  instance_transform = instance_transform * loc_matrix;
}
else {
  const float3 new_position = instance_transform.translation() + translation;
  copy_v3_v3(instance_transform.values[3], new_position);
}

This revision is now accepted and ready to land.Oct 12 2021, 12:06 AM

Hans Goudey (HooglyBoogly) requested changes to this revision.Oct 12 2021, 12:31 AM

Hans Goudey (HooglyBoogly) added inline comments.

source/blender/nodes/geometry/nodes/node_geo_translate_instances.cc
51–52	I have the same comment as the scale node here: I don't think this is quite right, the index here is the index into the mask, not the index of the index. Here's an example from the curve reverse node: threading::parallel_for(selection.index_range(), 128, [&](IndexRange range) { for (const int i : range) { splines[selection[i]]->reverse(); } });

This revision now requires changes to proceed.Oct 12 2021, 12:31 AM

Hans Goudey (HooglyBoogly) added inline comments.Oct 12 2021, 12:34 AM

source/blender/nodes/geometry/nodes/node_geo_translate_instances.cc
45–46	`extract_input`

Tomas (Rusculleda) awarded a token.Oct 12 2021, 1:03 AM

Fixed all review comments

Harbormaster completed remote builds in B17779: Diff 43225.Oct 13 2021, 12:47 AM

Small cleanups

Harbormaster completed remote builds in B17788: Diff 43234.Oct 13 2021, 6:04 AM

Hans Goudey (HooglyBoogly) accepted this revision.Oct 13 2021, 6:05 AM

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)

Hans Goudey (HooglyBoogly) added a reviewer: Jacques Lucke (JacquesLucke).

LGTM.
@Hans Goudey (HooglyBoogly) What's the state of moving the selection input to right after the geometry?

This revision is now accepted and ready to land.Oct 13 2021, 12:59 PM

Closed by commit rB9d49fc2ba0ec: Geometry Nodes: Translate Instances Node (authored by Erik Abrahamsson (erik85), committed by Hans Goudey (HooglyBoogly)). · Explain WhyOct 13 2021, 4:03 PM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rB9d49fc2ba0ec: Geometry Nodes: Translate Instances Node.

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

nodeitems_builtins.py

1 line

source/

blender/

blenkernel/

1 line

intern/

1 line

nodes/

1 line

1 line

NOD_static_types.h

1 line

geometry/

nodes/

node_geo_translate_instances.cc

89 lines

Diff 43225

release/scripts/startup/nodeitems_builtins.py

Loading...

source/blender/blenkernel/BKE_node.h

Loading...

source/blender/blenkernel/intern/node.cc

Loading...

source/blender/nodes/CMakeLists.txt

Loading...

source/blender/nodes/NOD_geometry.h

Loading...

source/blender/nodes/NOD_static_types.h

Loading...

source/blender/nodes/geometry/nodes/node_geo_translate_instances.cc

Loading...