Page MenuHome
Differential D12696

Fix T89864: Adding an asset referencing other objects adds it to scene but only adds data-blocks of referenced objects.
ClosedPublic
Actions

Authored by Bastien Montagne (mont29) on Sep 29 2021, 3:33 PM.

Details

Reviewers
Julian Eisel (Severin)
Group Reviewers
Asset Browser
Commits
rBdf9120b36538: Fix T89864: Adding an asset referencing other objects adds it to scene but only…
Summary

Link/append code needs proper access to scene/view3d data to handle
collections/objects instantiation.

Note that this is a temporary hack more than a proper fix, which would require
a deeper redesign of drag&drop code.

Diff Detail

Repository
rB Blender

Event Timeline

Bastien Montagne (mont29) requested review of this revision.Sep 29 2021, 3:33 PM
Bastien Montagne (mont29) created this revision.
Harbormaster completed remote builds in B17442: Diff 42667.Sep 29 2021, 3:33 PM
Bastien Montagne (mont29) added a reviewer: Asset Browser.Sep 29 2021, 3:33 PM
Julian Eisel (Severin) accepted this revision.Sep 29 2021, 3:42 PM
Julian Eisel (Severin) added a project: Asset Browser.
Julian Eisel (Severin) added a subscriber: Julian Eisel (Severin).

While this isn't not too nice, all this drag & drop code is rather hacky & clumsy. So I'm definitely fine with this.

This revision is now accepted and ready to land.Sep 29 2021, 3:42 PM
Closed by commit rBdf9120b36538: Fix T89864: Adding an asset referencing other objects adds it to scene but only… (authored by Bastien Montagne (mont29)). · Explain WhySep 29 2021, 5:11 PM
This revision was automatically updated to reflect the committed changes.
Bastien Montagne (mont29) added a commit: rBdf9120b36538: Fix T89864: Adding an asset referencing other objects adds it to scene but only….

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
interface/
7 lines
windowmanager/
7 lines
intern/
36 lines

Diff 42679

View Options

source/blender/editors/interface/interface.c

Loading...
View Options

source/blender/windowmanager/WM_types.h

Loading...
View Options

source/blender/windowmanager/intern/wm_dragdrop.c

Loading...