Page MenuHome
Differential D12701

Geometry Nodes: Add shader Musgrave texture node
ClosedPublic
Actions

Authored by Charlie Jolly (charlie) on Sep 29 2021, 5:27 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Jacques Lucke (JacquesLucke)
Commits
rB729b2d026d13: Geometry Nodes: Add shader Musgrave texture node
Summary

Port shader node musgrave texture

Diff Detail

Repository
rB Blender

Event Timeline

Charlie Jolly (charlie) requested review of this revision.Sep 29 2021, 5:27 PM
Charlie Jolly (charlie) created this revision.
Harbormaster completed remote builds in B17451: Diff 42683.Sep 29 2021, 5:28 PM
Charlie Jolly (charlie) added a comment.Sep 29 2021, 5:57 PM

Rough tests seems to validate it is producing the same output as Eevee/Cycles.

Charlie Jolly (charlie) added a comment.Sep 29 2021, 7:31 PM

Validated it matches shader musgrave by passing the position via attributes and using this to shade the mesh with the same settings.

gn_noise_musgrave.blend830 KBDownload

Charlie Jolly (charlie) updated this revision to Diff 42816.Oct 2 2021, 5:41 PM

Add auto vector input

Harbormaster completed remote builds in B17510: Diff 42816.Oct 2 2021, 5:41 PM
Charlie Jolly (charlie) added a project: Geometry Nodes.Oct 5 2021, 11:02 PM
Charlie Jolly (charlie) updated this revision to Diff 43359.EditedOct 15 2021, 10:54 AM

Tidy up after review of other texture patches

gn_musgrave_validation.blend841 KBDownload

Harbormaster completed remote builds in B17862: Diff 43359.Oct 15 2021, 10:54 AM
Charlie Jolly (charlie) updated this revision to Diff 43360.Oct 15 2021, 11:04 AM

Missed some const

Harbormaster completed remote builds in B17863: Diff 43360.Oct 15 2021, 11:04 AM
Jacques Lucke (JacquesLucke) added a comment.Oct 18 2021, 10:53 AM

Please update the patch for latest master.

Charlie Jolly (charlie) updated this revision to Diff 43475.Oct 18 2021, 11:17 AM

Rebase to master

Harbormaster completed remote builds in B17934: Diff 43475.Oct 18 2021, 11:17 AM
Jacques Lucke (JacquesLucke) accepted this revision.Oct 18 2021, 11:55 AM
Jacques Lucke (JacquesLucke) added inline comments.
source/blender/nodes/shader/nodes/node_shader_tex_musgrave.cc
342

Do the same thing we did in the voronoi node with the lambda functions.

This revision is now accepted and ready to land.Oct 18 2021, 11:55 AM
Charlie Jolly (charlie) marked an inline comment as done.Oct 18 2021, 12:28 PM
Charlie Jolly (charlie) updated this revision to Diff 43478.Oct 18 2021, 12:32 PM

Address comments

Harbormaster completed remote builds in B17936: Diff 43478.Oct 18 2021, 12:32 PM
Jacques Lucke (JacquesLucke) accepted this revision.Oct 18 2021, 12:37 PM
Closed by commit rB729b2d026d13: Geometry Nodes: Add shader Musgrave texture node (authored by Charlie Jolly (charlie)). · Explain WhyOct 18 2021, 3:39 PM
This revision was automatically updated to reflect the committed changes.
Charlie Jolly (charlie) added a commit: rB729b2d026d13: Geometry Nodes: Add shader Musgrave texture node.
Charlie Jolly (charlie) added a comment.Oct 18 2021, 3:42 PM

gn_musgrave_validation.blend849 KBDownload

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
1 line
source/
blender/
blenlib/
99 lines
intern/
718 lines
nodes/
shader/
nodes/
410 lines

Diff 43488

View Options

release/scripts/startup/nodeitems_builtins.py

Loading...
View Options

source/blender/blenlib/BLI_noise.hh

Loading...
View Options

source/blender/blenlib/intern/noise.cc

Loading...
View Options

source/blender/nodes/shader/nodes/node_shader_tex_musgrave.cc

Loading...