Page MenuHome
Differential D12718

Fix: fix warning icon on Curve to Mesh geometry node
ClosedPublic
Actions

Authored by Vitor Boschi (vitorboschi) on Sep 30 2021, 8:59 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Commits
rB3a59ddb2927c: Fix: Incorrect warning in curve to mesh node with instances
Summary

The node was setting a warning when used with instances on input, even though it worked fine.

Diff Detail

Repository
rB Blender

Event Timeline

Vitor Boschi (vitorboschi) requested review of this revision.Sep 30 2021, 8:59 PM
Vitor Boschi (vitorboschi) created this revision.
Vitor Boschi (vitorboschi) added a reviewer: Hans Goudey (HooglyBoogly).
Hans Goudey (HooglyBoogly) requested changes to this revision.Sep 30 2021, 9:07 PM

I think the node should still give a warning when there were non-empty instances and none of them contained curve data.

This revision now requires changes to proceed.Sep 30 2021, 9:07 PM
Vitor Boschi (vitorboschi) updated this revision to Diff 42743.Sep 30 2021, 10:20 PM

Keep the warning when the input is not empty and doesn't have any curve data.

Hans Goudey (HooglyBoogly) accepted this revision.Sep 30 2021, 10:56 PM

This works in my testing. If the geometry component had an empty instances component it may add a warning anyway, but I'm not sure it's worth handling that case anyway. Thanks for the patch!

source/blender/nodes/geometry/nodes/node_geo_curve_to_mesh.cc
63

This change to white-space is unnecessary.

This revision is now accepted and ready to land.Sep 30 2021, 10:56 PM
Vitor Boschi (vitorboschi) updated this revision to Diff 42751.Oct 1 2021, 12:50 AM

Re-add line that was mistakenly removed

Closed by commit rB3a59ddb2927c: Fix: Incorrect warning in curve to mesh node with instances (authored by Vitor Boschi (vitorboschi), committed by Hans Goudey (HooglyBoogly)). · Explain WhyOct 1 2021, 1:31 AM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rB3a59ddb2927c: Fix: Incorrect warning in curve to mesh node with instances.
Iliya Katueshenock (Moder) mentioned this in D16350: Cleanup: Delete unused variable.Oct 30 2022, 1:27 PM

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
geometry/
nodes/
23 lines

Diff 42743

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_to_mesh.cc

Loading...