Port White Noise shader to geometry nodes.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
| source/blender/blenlib/intern/noise.cc | ||
|---|---|---|
| 243 | [3/50] Building CXX object source/blender/blenlib/CMakeFiles/bf_blenlib.dir/intern/noise.cc.o
/home/jacques/blender-git/blender/source/blender/blenlib/intern/noise.cc:243:7: warning: no previous declaration for ‘float blender::noise::hash_float2_to_float(blender::float2)’ [-Wmissing-declarations]
243 | float hash_float2_to_float(float2 k)
| ^~~~~~~~~~~~~~~~~~~~
/home/jacques/blender-git/blender/source/blender/blenlib/intern/noise.cc:248:7: warning: no previous declaration for ‘float blender::noise::hash_float4_to_float(blender::float4)’ [-Wmissing-declarations]
248 | float hash_float4_to_float(float4 k)
| ^~~~~~~~~~~~~~~~~~~~I wonder, does this have to be a different function than hash_float_to_float(float2 k)? Maybe only one of the two is necessary. If only your new method is the one we should use, fine with me, but I'm not sure. Needs to be investigated. | |
| 248 | This function isn't used. | |
| 258 | That's probably for consistency, but it does look a bit unnecessary to hash the constant 1.0 as well. Fortunately, that will probably be optimized away by the compiler. | |
| source/blender/nodes/shader/nodes/node_shader_tex_white_noise.cc | ||
| 29 | This also needs a change in MOD_nodes_evaluator.cc in get_socket_value. | |
Comment Actions
Update to master. Dependent on D12725: Geometry Nodes: Add Voronoi Texture as hash functions need changing.
Comment Actions
This patch has to be updated for master a bit, but the code looks fine.
| source/blender/nodes/shader/nodes/node_shader_tex_white_noise.cc | ||
|---|---|---|
| 194 | No need to add this comment. | |