Differential D12721

Geometry Nodes: "Replace in String" node
ClosedPublic
Actions

Authored by Erik Abrahamsson (erik85) on Sep 30 2021, 11:00 PM.

Tags

Subscribers

Paul Larson (GeorgiaPacific)

Tokens

"Love" token, awarded by hitrpr."Love" token, awarded by VladimirM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Commits

rBa83b405a4524: Geometry Nodes: Replace String node

Summary

This patch adds a node that can be used to find and replace strings inside of the input string.

There are two modes:

Default, simple find and replace.
Regex, using regular expressions for more control.

Simple mode:

Regex mode:

Diff Detail

Repository: rB Blender

Event Timeline

Erik Abrahamsson (erik85) requested review of this revision.Sep 30 2021, 11:00 PM

Erik Abrahamsson (erik85) created this revision.

Paul Larson (GeorgiaPacific) added a subscriber: Paul Larson (GeorgiaPacific).Oct 2 2021, 1:19 AM

Messing with the regular expressions in T91692, I got the regular expression mode to throw an exception. This should be caught. Ideally that would be a warning message for the node too, but we don't have an API for warning messages from function/field nodes currently.

Other than that, it seemed to work quite well.

Maybe "Replace in String" is a more obvious name?

This revision now requires changes to proceed.Oct 5 2021, 7:23 AM

Renamed from "Replace String" to "Replace in String".
Catch and print regex_error exception.

Hans Goudey (HooglyBoogly) accepted this revision.Oct 5 2021, 8:03 PM

This revision is now accepted and ready to land.Oct 5 2021, 8:03 PM

Renamed again from "Replace in String" to "String Replace".

Mitranca Vladimir (VladimirM) awarded a token.Oct 6 2021, 7:57 AM

Rebased
Removed "is_function_node"

Harbormaster completed remote builds in B17830: Diff 43308.Oct 14 2021, 6:06 PM

Removed regex mode for now. Will be added as a separate patch after solving some design questions.

Harbormaster completed remote builds in B17950: Diff 43503.Oct 18 2021, 7:12 PM

Removed regex include

Harbormaster completed remote builds in B17951: Diff 43504.Oct 18 2021, 7:15 PM

Closed by commit rBa83b405a4524: Geometry Nodes: Replace String node (authored by Erik Abrahamsson (erik85), committed by Hans Goudey (HooglyBoogly)). · Explain WhyOct 19 2021, 10:28 PM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rBa83b405a4524: Geometry Nodes: Replace String node.

Vyacheslav (hitrpr) awarded a token.Dec 8 2021, 8:00 PM

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

nodeitems_builtins.py

1 line

source/

blender/

blenkernel/

1 line

intern/

1 line

nodes/

1 line

1 line

NOD_static_types.h

1 line

function/

nodes/

node_fn_replace_string.cc

67 lines

Diff 43605

release/scripts/startup/nodeitems_builtins.py

Loading...

source/blender/blenkernel/BKE_node.h

Loading...

source/blender/blenkernel/intern/node.cc

Loading...

source/blender/nodes/CMakeLists.txt

Loading...

source/blender/nodes/NOD_function.h

Loading...

source/blender/nodes/NOD_static_types.h

Loading...

source/blender/nodes/function/nodes/node_fn_replace_string.cc

Loading...