Page MenuHome

Geometry Nodes: Align Euler to Vector Node
ClosedPublic

Authored by Jarrett Johnson (jarrett.johnson) on Oct 1 2021, 2:15 PM.

Details

Summary

This commit introduces the Align Euler to Vector function node which rotates to a body into a given direction. Addresses T91374.

Diff Detail

Repository
rB Blender

Event Timeline

Jarrett Johnson (jarrett.johnson) requested review of this revision.Oct 1 2021, 2:15 PM
Jarrett Johnson (jarrett.johnson) created this revision.
Jarrett Johnson (jarrett.johnson) retitled this revision from Align euler to vector to Geometry Nodes: Align Euler to Vector Node.Oct 1 2021, 3:04 PM
Jarrett Johnson (jarrett.johnson) edited the summary of this revision. (Show Details)
source/blender/nodes/function/nodes/node_fn_align_euler_to_vector.cc
148

I don't have a clang-tidy setup yet (hard to figure out on Windows), but I think this going to fire an else-after-return warning. I'll fix this and and also add an unreachable assert at the end of this function.

source/blender/nodes/function/nodes/node_fn_align_euler_to_vector.cc
149–151

I don't think this will work, because the same multi-function could be used by multiple threads that use different pivot axes.
There could be three different static multi-functions I suppose, which would still avoid allocating a new one every time.

  • Merge branch 'master' into fn_align_euler_to_vector
  • create dynamic multifunction
source/blender/nodes/function/nodes/node_fn_align_euler_to_vector.cc
169

Looks like this isn't using the mask, the static functions above should use that to avoid doing unnecessary calculations.

This revision is now accepted and ready to land.Oct 9 2021, 9:34 PM