Page MenuHome

Geometry Nodes: Add Shader Image texture node
AbandonedPublic

Authored by Charlie Jolly (charlie) on Oct 3 2021, 1:09 AM.

Details

Summary

Port shader image texture node.

Superceded by D12827: Geometry Nodes: Add Image Texture node.

Core devs: Please take over if you want to.

Diff Detail

Repository
rB Blender
Branch
arcpatch-D12734 (branched from master)
Build Status
Buildable 17753
Build 17753: arc lint + arc unit

Event Timeline

Charlie Jolly (charlie) requested review of this revision.Oct 3 2021, 1:09 AM
Charlie Jolly (charlie) created this revision.

Move some code out of the loop.

Add support for tube and sphere projections

Charlie Jolly (charlie) updated this revision to Diff 42953.EditedOct 6 2021, 2:36 AM

Latest work in progress. In current form it is working as a basic replacement for the Attribute Sample Texture node.

Charlie Jolly (charlie) edited the summary of this revision. (Show Details)Oct 6 2021, 2:46 AM

Add cubic sampling.
Current WIP state.

Charlie Jolly (charlie) planned changes to this revision.Oct 6 2021, 1:36 PM

Add support for Clip, Repeat and Extend.

Add alpha support.

Update sample code to match Cycles.

@Hans Goudey (HooglyBoogly) @Dalai Felinto (dfelinto) Image Node patch is in a much better state. I ported the cycles code rather than the image texture code. I feel this is in a decent place for general review and feedback.

I've not yet looked at supporting tiled images but this could be added later.

I've been using this for the flowers demo (needs custom branch). So far it works great, thanks.

My only remark is whether there is a way for the active UV to be the fallback for the Vector input.

PS: If the patch is ready, could you please remove the "wip" from its title?

Tidy up. Remove comments. Add support for image sequences by including NTREE_GEOMETRY in the image walker.

Projection notes: The projection modes, Sphere, Tube and Box expect UV coords. The remapping is not exposed in the UI but possibly this should be. I guess these projections are not used much.

@Dalai Felinto (dfelinto) For the default, there is a note in MOD_nodes_evaluator.cc that the defaults need more work.

/* This is not supposed to be a long term solution. Eventually we want that nodes can specify
 * more complex defaults (other than just single values) in their socket declarations. */
Charlie Jolly (charlie) retitled this revision from Geometry Nodes: Add Image texture node (WIP) to Geometry Nodes: Add Image texture node.Oct 7 2021, 2:00 PM
Charlie Jolly (charlie) edited the summary of this revision. (Show Details)

Update after changes in master

@Charlie Jolly (charlie) can you expose the image input as a socket?

Merging latest master in.

Charlie Jolly (charlie) retitled this revision from Geometry Nodes: Add Image texture node to Geometry Nodes: Add Shader Image texture node.
Charlie Jolly (charlie) edited the summary of this revision. (Show Details)