Page MenuHome

Fix T91096: VSE use after free with overwrite enabled
ClosedPublic

Authored by Richard Antalik (ISS) on Oct 5 2021, 12:12 AM.

Details

Summary

Strip was flagged for deletion in seq_transform_handle_overwrite()
on STRIP_OVERLAP_IS_FULL. Then it is removed in
SEQ_edit_strip_split() before it should be.

Handle STRIP_OVERLAP_IS_FULL in separate loop.

I think, that this is not complete solution, because in example file
overlap is caused between 2 transformed strips and one "static" in 2
different ways. Such operation should not be possible in first place.
It fixes crash at lest, so improvement in behavior can be handled
separately.

Diff Detail

Repository
rB Blender
Branch
T91096 (branched from master)
Build Status
Buildable 17558
Build 17558: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.Oct 5 2021, 12:12 AM
Richard Antalik (ISS) created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Oct 9 2021, 10:14 AM
This revision was automatically updated to reflect the committed changes.