Paths

Table of Contentst

Differential D12762

Geometry Nodes: Add Checker Texture
ClosedPublic
Actions

Authored by Charlie Jolly (charlie) on Oct 6 2021, 12:52 AM.

Tags

Subscribers

Paul Larson (GeorgiaPacific)

Zach Eastin (Bariboy)

Details

Reviewers

Hans Goudey (HooglyBoogly)
Jacques Lucke (JacquesLucke)

Commits

rB2537b3239240: Geometry Nodes: Add Checker Texture

Summary

Port checker shader to GN

Diff Detail

Repository: rB Blender

Event Timeline

Charlie Jolly (charlie) requested review of this revision.Oct 6 2021, 12:52 AM

Charlie Jolly (charlie) created this revision.

Harbormaster completed remote builds in B17585: Diff 42949.Oct 6 2021, 12:52 AM

gn_checker_texture_validation.blend868 KBDownload

Add check to see if color needs to be computed.

Harbormaster completed remote builds in B17586: Diff 42950.Oct 6 2021, 1:02 AM

Paul Larson (GeorgiaPacific) added a subscriber: Paul Larson (GeorgiaPacific).Oct 6 2021, 7:17 PM

Rebase after recent changes in master

Harbormaster completed remote builds in B17637: Diff 43024.Oct 7 2021, 8:57 PM

Jacques Lucke (JacquesLucke) requested changes to this revision.Oct 14 2021, 3:48 PM

Jacques Lucke (JacquesLucke) added inline comments.

source/blender/nodes/shader/nodes/node_shader_tex_checker.cc
88	The `blender::` part is not necessary.
101	Comment style. Can you provide an example for where this is necessary?

This revision now requires changes to proceed.Oct 14 2021, 3:48 PM

Charlie Jolly (charlie) marked 2 inline comments as done.Oct 14 2021, 4:26 PM

Charlie Jolly (charlie) added inline comments.

source/blender/nodes/shader/nodes/node_shader_tex_checker.cc
101	This is taken from the Cycles code. This may be less of an issue with GN but with the shader you can see the issue dating back to T51951 and the fix rB3232d8ec8f15. The same code is in Wave Texture too.

Address comments

Harbormaster completed remote builds in B17837: Diff 43322.Oct 14 2021, 8:25 PM

Rebase to master

Harbormaster completed remote builds in B17998: Diff 43568.Oct 19 2021, 2:36 PM

This is missing the change in nodeitems_builtins.py.

source/blender/nodes/shader/nodes/node_shader_tex_checker.cc
88	This comment is still valid.

This revision now requires changes to proceed.Oct 19 2021, 3:13 PM

Charlie Jolly (charlie) marked an inline comment as done.Oct 19 2021, 6:54 PM

Address comments

Harbormaster completed remote builds in B18016: Diff 43599.Oct 19 2021, 7:12 PM

Zach Eastin (Bariboy) added a subscriber: Zach Eastin (Bariboy).Oct 20 2021, 4:01 PM

Please add a file to compare this to cycles to the summary.

This revision is now accepted and ready to land.Oct 20 2021, 4:02 PM

Closed by commit rB2537b3239240: Geometry Nodes: Add Checker Texture (authored by Charlie Jolly (charlie)). · Explain WhyOct 20 2021, 5:46 PM

This revision was automatically updated to reflect the committed changes.

Charlie Jolly (charlie) added a commit: rB2537b3239240: Geometry Nodes: Add Checker Texture.

gn_checker_validation.blend920 KBDownload

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

nodeitems_builtins.py

1 line

source/

blender/

nodes/

shader/

nodes/

node_shader_tex_checker.cc

68 lines

Diff 43644

release/scripts/startup/nodeitems_builtins.py

Loading...

source/blender/nodes/shader/nodes/node_shader_tex_checker.cc

Loading...