Confirm scene and view layer deletion
Needs ReviewPublic
Actions

Authored by Falk David (filedescriptor) on Oct 6 2021, 10:18 AM.

Details

Reviewers: None

Summary

The SCENE_OT_delete and SCENE_OT_view_layer_remove operators did
not require any confirmation. Since the "New" and "Delete" buttons are
right next to each other, I think it would make sense to ask for
confirmation before deleting a scene or a view layer.

Note that this does not affect python scripts that call e.g.

>>> bpy.ops.scene.delete()

Diff Detail

Repository

rB Blender

Branch

temp-confirm-scene-view-layer-deletion (branched from master)

Build Status

Buildable 17591
Build 17591: arc lint + arc unit

Event Timeline

Falk David (filedescriptor) requested review of this revision.Oct 6 2021, 10:18 AM

Falk David (filedescriptor) created this revision.

Harbormaster completed remote builds in B17591: Diff 42960.Oct 6 2021, 10:18 AM

Falk David (filedescriptor) edited the summary of this revision. (Show Details)Oct 6 2021, 10:20 AM

Falk David (filedescriptor) added a project: BF Blender.

Falk David (filedescriptor) retitled this revision from Confirm scene and viewlayer deletion to Confirm scene and view layer deletion.

stefano severi (Tetone) awarded a token.Oct 6 2021, 6:10 PM

Carlos Muñoz (carlosmu) awarded a token.Oct 12 2021, 9:07 PM

Confirmation popups like this should be avoided. They seem like a simple solution, but the more we use them the more we allow users to form the habit to click them away, without paying attention. And then they will click them away by habit when they don't mean to, and when there's no way to undo the change. If this happens, it's a big design failure.
(There already are a few instances in Blender where we show a confirmation popup where we probably shouldn't.)
See https://wiki.blender.org/wiki/Human_Interface_Guidelines/Dialogs and the links provided there.

Removing a scene or view layer are both changes that can be undone. I think we should keep it at that.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

render/

render_shading.c

1 line

scene/

scene_edit.c

1 line

Diff 42960

View Options

source/blender/editors/render/render_shading.c