Fix: Stops assert when baking in debug mode.
ClosedPublic
Actions

Authored by William Leeson (leesonw) on Oct 6 2021, 4:38 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Brecht Van Lommel (brecht)

Commits

rB3021babf38f8: Fix: Stops assert when baking in debug mode.

Summary

When baking in a debug build running gdb it kept asserting because a GL context was being created outside the main thread.

To fix this the patch only creates the GL context is only created for rendering (when it is actually used).

Diff Detail

Repository: rB Blender

Event Timeline

William Leeson (leesonw) requested review of this revision.Oct 6 2021, 4:38 PM

William Leeson (leesonw) created this revision.

Harbormaster completed remote builds in B17600: Diff 42975.Oct 6 2021, 4:38 PM

William Leeson (leesonw) edited the summary of this revision. (Show Details)Oct 6 2021, 4:41 PM

William Leeson (leesonw) added a reviewer: Sergey Sharybin (sergey).

William Leeson (leesonw) added a project: Cycles.

This breaks F12 render which is also background but which does need DisplayDriver to be created.

Since we only expect the DisplayDriver to be used for rendering, perhaps easiest is to only create display for render: P2485
Need to check viewport OpenGL context is created from the main thread still though.

This revision now requires changes to proceed.Oct 6 2021, 5:07 PM

Applied fix suggested by Sergey that only creates the display for render.

Sergey Sharybin (sergey) accepted this revision.Oct 13 2021, 9:44 AM

Sergey Sharybin (sergey) added a reviewer: Brecht Van Lommel (brecht).

William Leeson (leesonw) retitled this revision from Fix for assert when baking in debug mode. to Fix: Stops assert when baking in debug mode..Oct 13 2021, 11:02 AM

William Leeson (leesonw) edited the summary of this revision. (Show Details)Oct 13 2021, 11:06 AM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 13 2021, 11:10 AM

Closed by commit rB3021babf38f8: Fix: Stops assert when baking in debug mode. (authored by William Leeson (leesonw)). · Explain Why

This revision was automatically updated to reflect the committed changes.

William Leeson (leesonw) added a commit: rB3021babf38f8: Fix: Stops assert when baking in debug mode..

William Leeson (leesonw) mentioned this in T92177: Crash when selecting cycles as viewport renderer.Oct 13 2021, 1:33 PM

William Leeson (leesonw) added a reverting change: D12853: Fixes T92177: Crash in debug build when switching to preview rendering..Oct 13 2021, 1:42 PM