Page MenuHome

VSE: Share thumbnails between strips
Changes PlannedPublic

Authored by Richard Antalik (ISS) on Oct 7 2021, 5:46 AM.

Details

Reviewers
None
Maniphest Tasks
T91618: VSE thumbnails improvements
Summary

If strip is split or duplicated, thumbnails are rendered twice, even
though source file is same for both strips. This is mainly due to cache
design.

This patch allows for sharing of images between strips.

Quick testing of implementation revealed some issues:

  • Normally thumbnails out of view were freed, once too many thumbnails are cached. There is no good way of checking to what frame this strip belongs to if it is shared between strips however. Not sure how to resolve this problem.
  • This method is using string for hashing, but frame number needs to be appended, which is not nice.
  • Adding support for strips that reference other data like movieclip or scene could be problematic, but at least it will increase complexity.

Otherwise it works relatively well.

ref T91618

Diff Detail

Repository
rB Blender
Branch
thumb-shared-cache (branched from master)
Build Status
Buildable 17616
Build 17616: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.Oct 7 2021, 5:46 AM
Richard Antalik (ISS) created this revision.
Richard Antalik (ISS) planned changes to this revision.Oct 7 2021, 5:47 AM

Draft - not for review yet

Normally thumbnails out of view were freed, once too many thumbnails are cached. There is no good way of checking to what frame this strip belongs to if it is shared between strips however. Not sure how to resolve this problem.

I think this could be solved by adding list of strips (effectively) using cache item. This will have to be managed, but only strip removal, which is not that evil I think. Adding strips to list can be managed by ensuring, that each strip, that requests image is added.