Page MenuHome

Fix T91700: Transform gizmos visible in scope view
AbandonedPublic

Authored by Richard Antalik (ISS) on Oct 7 2021, 6:21 AM.

Details

Summary

Hide transform gizmos and tools when preview is set to displaying scopes
instead of image.

Diff Detail

Repository
rB Blender
Branch
T91700 (branched from master)
Build Status
Buildable 17617
Build 17617: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.Oct 7 2021, 6:21 AM
Richard Antalik (ISS) created this revision.

Committed alternate fix rB746ee29d3638402e2435f47787087b6458f026c7,

since transform shouldn't be able to be activated at all (hiding tools doesn't prevent transform from key-bindings for example).

As for hiding tools, this should take mixed preview/timeline into account, currently this patch hides all tools in that case.


The correct solution in this case is to have a poll function for every tool, this would allow some tools to be added later that work in the scope view.

Although the current state - that tools do nothing, isn't so bad IMHO, scope views are often set temporarily, complicating tool logic to account for this may be overkill.

Sounds reasonable, I will close this patch then