Page MenuHome

User Interface: Remove the green background when inside a node group
ClosedPublic

Authored by Dalai Felinto (dfelinto) on Oct 7 2021, 4:59 PM.
Tokens
"Love" token, awarded by TheCharacterhero."Love" token, awarded by billreynish."Love" token, awarded by lone_noel."Love" token, awarded by LazyDodo."Love" token, awarded by HooglyBoogly.

Details

Summary

The current background color and parent nodetrees is too distracting and noisy.
It drastically affect the readability of the nested node-trees.

Other techniques (better bread crumbs) can be used instead to indicate
to users that they are inside a node group.


The background drawing was introduced in 4638e5f99a9ba as part of the
Python Nodes branch merge. This made its debut in Blender 2.67
(30/May/2021).

At the time the color used for the background was a light gray. Over the
years the color changed to the current dark green, aggravating the
problem further.

Before that, the (expanded) nodegroup already had the partially
transparent background, mingling with the other nodes. The Python Nodes
branch brought this concept with its changes, and would always draw up
to two levels up in the background (the parent nodetree, and its parent
nodetree).

To read the original inspiration for all the changes introduced then:
https://code.blender.org/2012/01/improving-node-group-interface-editing/


Not to be included in the commit message:

2.66 node groups:

2.67 node groups:

2.93 node groups:

This patch:

Diff Detail

Repository
rB Blender
Branch
nodes-background-remove-green (branched from master)
Build Status
Buildable 17633
Build 17633: arc lint + arc unit

Event Timeline

Dalai Felinto (dfelinto) requested review of this revision.Oct 7 2021, 4:59 PM
Dalai Felinto (dfelinto) created this revision.
Dalai Felinto (dfelinto) edited the summary of this revision. (Show Details)Oct 7 2021, 5:08 PM
RedMser (RedMser) added inline comments.
source/blender/editors/space_node/node_draw.cc
2243

Comment is outdated.

Finally! Thanks for working on it!

This revision is now accepted and ready to land.Oct 7 2021, 5:23 PM

And pushed! Fixed the comment before committing, thanks for the review @RedMser (RedMser)