In D12783#337426, @Jacques Lucke (JacquesLucke) wrote:

Are you aware of any reason why the node has some inputs that are not sockets? Changing that is out of scope now, I'm just wondering.

@Thomas Dinges (dingto) I think you did the original port to Cycles. Can you answer @Jacques Lucke (JacquesLucke) question?

Address comments.

Harbormaster completed remote builds in B17843: Diff 43329.Oct 14 2021, 9:31 PM

gn_brick_validation.blend857 KBDownload

Rebase to master

Harbormaster completed remote builds in B18018: Diff 43601.Oct 19 2021, 7:41 PM

Zach Eastin (Bariboy) added a subscriber: Zach Eastin (Bariboy).Oct 20 2021, 4:01 PM

Jacques Lucke (JacquesLucke) accepted this revision.Oct 26 2021, 4:05 PM

This revision is now accepted and ready to land.Oct 26 2021, 4:05 PM

Closed by commit rB52ccb445011d: Geometry Nodes: Add Brick Texture node (authored by Charlie Jolly (charlie)). · Explain WhyOct 26 2021, 4:40 PM

This revision was automatically updated to reflect the committed changes.

Charlie Jolly (charlie) added a commit: rB52ccb445011d: Geometry Nodes: Add Brick Texture node.

Geometry Nodes: Add Brick Texture
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 43978

release/scripts/startup/nodeitems_builtins.py

source/blender/nodes/shader/nodes/node_shader_tex_brick.cc

Geometry Nodes: Add Brick TextureClosedPublicActions