Page MenuHome
Differential D12794

Fix crash in the node editor in cases where nodetree was empty
ClosedPublic
Actions

Authored by Dalai Felinto (dfelinto) on Oct 8 2021, 4:03 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Commits
rB38c4888f0999: Fix crash in the node editor in cases where nodetree was empty
Summary

This seems to happen only in a few files, and not so trivial to reproduce from scratch.

The crash is real though, and this fixes it.

Bug introduced on ebe23745281e86.

Diff Detail

Repository
rB Blender
Branch
fix-crash (branched from master)
Build Status
Buildable 17662
Build 17662: arc lint + arc unit

Event Timeline

Dalai Felinto (dfelinto) requested review of this revision.Oct 8 2021, 4:03 PM
Dalai Felinto (dfelinto) created this revision.
Harbormaster completed remote builds in B17660: Diff 43056.Oct 8 2021, 4:03 PM
Dalai Felinto (dfelinto) updated this revision to Diff 43057.Oct 8 2021, 4:05 PM

Fixup

Harbormaster completed remote builds in B17661: Diff 43057.Oct 8 2021, 4:05 PM
Sergey Sharybin (sergey) accepted this revision.Oct 8 2021, 4:10 PM
Sergey Sharybin (sergey) added a subscriber: Sergey Sharybin (sergey).
Sergey Sharybin (sergey) added inline comments.
source/blender/editors/space_node/node_draw.cc
2181
This revision is now accepted and ready to land.Oct 8 2021, 4:10 PM
Dalai Felinto (dfelinto) retitled this revision from Fix crash in the node editor to Fix crash in the node editor in cases where nodetree was empty.Oct 8 2021, 4:14 PM
Dalai Felinto (dfelinto) edited the summary of this revision. (Show Details)
Dalai Felinto (dfelinto) edited the summary of this revision. (Show Details)
Dalai Felinto (dfelinto) updated this revision to Diff 43058.Oct 8 2021, 4:15 PM

From review: fix comment style

Harbormaster completed remote builds in B17662: Diff 43058.Oct 8 2021, 4:15 PM
Closed by commit rB38c4888f0999: Fix crash in the node editor in cases where nodetree was empty (authored by Dalai Felinto (dfelinto)). · Explain WhyOct 8 2021, 4:17 PM
This revision was automatically updated to reflect the committed changes.
Dalai Felinto (dfelinto) added a commit: rB38c4888f0999: Fix crash in the node editor in cases where nodetree was empty.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_node/
12 lines

Diff 43058

View Options

source/blender/editors/space_node/node_draw.cc

Loading...