Page MenuHome

UI: Cleanup movie clip background images
AbandonedPublic

Authored by Aaron Carlisle (Blendify) on Oct 9 2021, 4:33 AM.

Details

Reviewers
None
Group Reviewers
User Interface
Summary

Cleans up the Movie clip settings by hiding properties that do not function in the current context.
The order of properties was also adjusted to prevent content jumping around while switching modes.

BeforeAfter

Active Clip Enabled

BeforeAfter

Diff Detail

Event Timeline

Aaron Carlisle (Blendify) requested review of this revision.Oct 9 2021, 4:33 AM
Aaron Carlisle (Blendify) created this revision.
Aaron Carlisle (Blendify) edited the summary of this revision. (Show Details)
Aaron Carlisle (Blendify) planned changes to this revision.Oct 10 2021, 7:05 PM
Aaron Carlisle (Blendify) added inline comments.
release/scripts/startup/bl_ui/properties_data_camera.py
332

I think it would make a lot of sense to make this an enum, "Clip Source"

Aaron Carlisle (Blendify) edited the summary of this revision. (Show Details)

Update with master

We generally avoid hiding UI elements, unless it actually helps understanding context or the UI is expected to do so (e.g. in context menus). Graying out is preferred, since it doesn't confuse users when they are looking for a specific option. The UI stays predictable/familiar, and doesn't change depending on context. Plus, users can still invoke the tooltip, in which we can give more information about why some option isn't available (which isn't supported well enough in Python yet).

I think it's useful to display what the active clip is. Also, the selection of the clip logically should really be above Render Undistorted and Proxy Render Size.

I don't think we need to change anything here.