Page MenuHome

Sequencer: Expose preview transform operators in menu
ClosedPublic

Authored by Aaron Carlisle (Blendify) on Oct 9 2021, 10:16 PM.

Details

Summary

The also moves all the image operators into one menu.
The goal here is to expose the operators in the UI so they
work with the operator search and to make the UI consistent.

Diff Detail

Repository
rB Blender

Event Timeline

Aaron Carlisle (Blendify) requested review of this revision.Oct 9 2021, 10:16 PM
Aaron Carlisle (Blendify) created this revision.
  • Remove unneed operator context assignment

Generally fine, note that we should get the terminology consistent, this patch calls this "image" which implies this is for image-strips (excluding movies, scenes etc).

This is an issue for operator naming too.

Not sure what the correct term here would be, maybe "Media"? I'm open the suggestions.

This patch should also serve as a base for the other operators that will be added as part of T91998 so we should keep this in mind when considering naming.

Note that Blender currently contains these in an "Image" menu so there is no regression in terminology.

@Aaron Carlisle (Blendify) When the Preview got transform tools , it became an "editor". Imo, should the operators relating to operations in the "Preview editor" be exposed there, since this is where users will expect them(and not in the Sequencer view). I've already done a patch which does this and adds several of the obvious missing operators like selection/duplicate/copy/paste etc.: https://developer.blender.org/D12513

Yes I think it is responsible to add the selecting operators. I am however unsure about operators that affect strips such as copy/paste, duplicate, ect... it makes sense however as shown in your patch it presents itself with some UX issues.

Imo we should just keep it simple for 3.0 and implement what is in this patch and also select operators.

For 3.1 when more operators get added we can reevaluate those operators.

Yes I think it is responsible to add the selecting operators. I am however unsure about operators that affect strips such as copy/paste, duplicate, ect... it makes sense however as shown in your patch it presents itself with some UX issues.

What issues?

I think it is fine to have strip image top level menu. But you are still operating on strips strictly speaking, especially with delete and copy/paste operators.

As far as naming, "Media" would perhaps imply IO operations on input, so "Image" is IMO better. Perhaps if it is not obvious what image is meant, it should be second level menu item?

If the Image menu is inserted in Preview and inserted as Image Transform submenu, as in my patch, it makes sense. In the Image Editor the menu is also called Image.

I think this is clear enough.

This revision is now accepted and ready to land.Oct 26 2021, 2:44 AM
Aaron Carlisle (Blendify) retitled this revision from Sequencer: Expose transform operators in menu to Sequencer: Expose preview transform operators in menu.Oct 26 2021, 4:17 AM