Differential D12809
UI: View2D: Align vertical indicators to view Authored by Pablo Vazquez (pablovazquez) on Oct 10 2021, 7:26 PM.
Details
In editors with vertical scale indicators, such as Graph Editor, Also add a shadow (similar to the 3D View info) to improve readability when the text is on top of curves, strips, or other content. 
Diff Detail
Event TimelineComment Actions Nice change! The numbers seem to be approximately a pixel too high in the graph editor, and slightly more in the Sequencer. I find it more noticeable in the Graph Editor because they all sit on top of the lines whose values’ they label. Did you experiment with other offsets? Comment Actions Thanks! You were right about the alignment especially in the VSE. I tried different offsets but they didn't always align. I've now switched to use BLF_height to get the height of the string and divide it by 2 (then the infamous U.pixelsize offset). This one seems to do the trick! Also I assume it's more future proof if the font size or font family changes. Comment Actions @Campbell Barton (campbellbarton) could you please check if I'm doing the right thing here? I'm calculating the height of the text and halving it so it's center, which I think it's correct but perhaps is overkill. Thanks! Comment Actions
There's probably not really a need to calculate the height of the entire string and do it inside the loop. I'd consider just getting the height of a digit "0" and do so before the loop, like this: ...
const float ymax = rect->ymax;
const float y_offset = (BLF_height(font_id, "0", 1) / 2.0f) - U.pixelsize;
for (uint i = 0; i < steps; i++) {
...Comment Actions Applied suggestions by @Harley Acheson (harley). Thanks! Also increment the left padding a bit so it doesn't overlap with the sources-list toggle widget. Comment Actions Think this is ready. It's a clear improvement to me. Of course there are still issues with very low zooming levels, but it's a separate issue and I don't think your patch makes that worse.
Comment Actions Use BLF_height_max instead of BLF_height, suggested by @Julian Eisel (Severin). Thanks for taking the time to review! Comment Actions With this item it is pretty important that the height used is correct so that it vertically centers correctly. Even out a pixel can make it line up oddly with the nearby line. That BLF_height_max is basically the height of the tallest character in the font (bounding box xMax - xMin) . Are 0-9 always as tall as the tallest characters in the font? No, there are are fonts where the descenders are greater than ascenders, so p will be taller than an f, and so numbers will be not as tall as the maximum. Note this bounding box cannot take Hinting into account so can be out by a pixel or more if hinting is enabled. With OpenType variable fonts this bounding box is not updated even though some changes can affect the height. Best to just measure a "0" as I mentioned above. Edited: In our DejaVuSans the characters "$()[[]" are all taller than the numbers, so the height of the digits is less than font max height. Will be close at small sizes though. | ||||||||||||||||