Page MenuHome

UI: Improve contrast on playhead
ClosedPublic

Authored by Pablo Vazquez (pablovazquez) on Oct 10 2021, 8:35 PM.
Tokens
"Love" token, awarded by HEYPictures."Like" token, awarded by mistrzjang."Like" token, awarded by Fracture128."Love" token, awarded by harley.

Details

Summary

Add an outine around the playhead, matching the color of the background (slightly darkened)
to improve the readability of the current frame line when placed against curves or strips
with a similar color.

Diff Detail

Repository
rB Blender

Event Timeline

Pablo Vazquez (pablovazquez) requested review of this revision.Oct 10 2021, 8:35 PM
Pablo Vazquez (pablovazquez) created this revision.
Campbell Barton (campbellbarton) added inline comments.
source/blender/editors/animation/time_scrub_ui.c
104

Values below 1 are set to zero, suggest to use a rounding so larger values aren't always rounded down.

120–122

This reads a little more clearly to me.

Pablo Vazquez (pablovazquez) marked 2 inline comments as done.Oct 12 2021, 2:16 AM
Pablo Vazquez (pablovazquez) added inline comments.
source/blender/editors/animation/time_scrub_ui.c
104

Oh didn't think of that, good point. Thanks!

120–122

Indeed it reads a lot better!

This revision was not accepted when it landed; it landed in state Needs Review.Oct 17 2021, 7:10 PM
This revision was automatically updated to reflect the committed changes.
Pablo Vazquez (pablovazquez) marked 2 inline comments as done.