Fix T91012: Scene strip doesn't play audio
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Oct 11 2021, 10:11 AM.

Details

Reviewers

Sebastian Parborg (zeddb)
Sergey Sharybin (sergey)

Maniphest Tasks

T91012: VSE: Scene strip doesn't play audio

Commits

rB42ab4b60bd45: Fix T91012: Scene strip doesn't play audio
rB81514b0e913b: Fix T91012: Scene strip doesn't play audio

Summary

Issue was caused by adding seq->sound check in ded68fb10275 in
function BKE_sound_scene_add_scene_sound as offset_time field was
introduced to resolve sub-frame a/v misalignment.

Scene strips don't have bSound allocated but also don't suffer from
a/v misalignment.

Add function BKE_sound_offset_time_from_sequence_get to access
offset_time value even if Sequence has no bSound.

Diff Detail

Repository

rB Blender

Branch

T91012 (branched from master)

Build Status

Buildable 17705
Build 17705: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.Oct 11 2021, 10:11 AM

Richard Antalik (ISS) created this revision.

Harbormaster completed remote builds in B17705: Diff 43118.Oct 11 2021, 10:12 AM

Now looking at this again, this offset value cold be removed completely from BKE_sound_scene_add_scene_sound as this is "merging" sound of 2 scenes together. This would be probably same for SEQ_sound_update_bounds too.