Fix for T91979: Make String Length Output not a field
ClosedPublic
Actions

Authored by Erik Abrahamsson (erik85) on Oct 11 2021, 8:05 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T91979: Make String Length Output not a field

Commits

rBc1d138dd926c: Fix T91979: Don't mark string nodes as supporting fields

Summary

Make the string-nodes' in-/outputs not look
like the can handle a field (which they can't)
by removing the call to is_function_node().

Diff Detail

Repository: rB Blender

Event Timeline

Erik Abrahamsson (erik85) requested review of this revision.Oct 11 2021, 8:05 PM

Erik Abrahamsson (erik85) created this revision.

In this case I just take issue with the patch description, specifically "which they can't", because the nodes _can_ handle fields, there just don't happen to be any string field inputs currently. Hopefully there will be in the future.
But as a temporary fix to stop people from having to wonder about that, this looks good.

This revision is now accepted and ready to land.Oct 11 2021, 8:46 PM

Hans Goudey (HooglyBoogly) added a task: T91979: Make String Length Output not a field.Oct 18 2021, 2:12 PM

Closed by commit rBc1d138dd926c: Fix T91979: Don't mark string nodes as supporting fields (authored by Erik Abrahamsson (erik85), committed by Hans Goudey (HooglyBoogly)). · Explain WhyOct 19 2021, 2:08 AM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rBc1d138dd926c: Fix T91979: Don't mark string nodes as supporting fields.