Replaces the old Subdivision Surface Node.
Changes:
- Removes implicit instance realization
- Use_creases becomes a Crease Factor field applied to edges.
Addresses T91763
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- mesh_subdivision (branched from master)
- Build Status
Buildable 17734 Build 17734: arc lint + arc unit
Event Timeline
| source/blender/nodes/geometry/nodes/node_geo_subdivision_surface.cc | ||
|---|---|---|
| 96–107 | I guess I wasn't totally clear before, sorry about that, but the crease should be evaluated as a float and stored in the MEdge.crease (or passed to the subdivision process in some other way) if it's necessary (the use_creases condition hear evaluates to true). Otherwise it don't be possible to use different crease values for every vertex. | |
| source/blender/nodes/geometry/nodes/node_geo_subdivision_surface.cc | ||
|---|---|---|
| 96–107 | It makes much more sense now. Thanks. | |
Comment Actions
Still WIP for now, but seems workable. I want to test the smoothing modes first before I add reviewers.
| source/blender/nodes/geometry/nodes/node_geo_subdivision_surface.cc | ||
|---|---|---|
| 96 | [1/3] Building CXX object source/blender/nodes/CMakeFiles/bf_nodes.dir/geometry/nodes/node_geo_subdivision_surface.cc.o
/home/jacques/blender-git/blender/source/blender/nodes/geometry/nodes/node_geo_subdivision_surface.cc:102:5: warning: 'auto &creases' can be declared as 'const auto &creases' [readability-qualified-auto]
auto &creases = evaluator.get_evaluated<float>(0);
^
constUse the type name instead of auto. | |
| 99 |
To see the bug, change the second input in the Add node. | |
| source/blender/nodes/geometry/nodes/node_geo_subdivision_surface.cc | ||
|---|---|---|
| 92 | And an empty line before here and after const VArray<float> &creases = evaluator.get_evaluated<float>(0);. | |
Comment Actions
This is a nice intuitive way to control the crease, I like it. Thanks for the patch Jarrett!
I'll do a few small cleanups when committing:
- No need for two separate mesh component variables
- Rename a few variables slightly
- Add PROP_FACTOR to crease input so it draws with a slider.
I also renamed "Crease Factor" to "Crease". Having "Factor" in the name implied that it's multiplied with something, which isn't true.