Fix T92103: Update BLI hash_float_to_float functions to be shader compatible
ClosedPublic
Actions

Authored by Charlie Jolly (charlie) on Oct 11 2021, 11:34 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)
Jacques Lucke (JacquesLucke)

Maniphest Tasks

T92103: Geometry Nodes noise does not match Cycles

Commits

rBe005ad5b5476: Fix T92103: Update BLI hash_float_to_float functions to be shader compatible

Summary

Previously the functions called hash_float instead of uint_to_float_01.
This meant that the float was hashed twice instead of once.
The new functions are also compatible with Cycles/Eevee.

Fix T92103

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 17736
Build 17736: arc lint + arc unit

Event Timeline

Charlie Jolly (charlie) requested review of this revision.Oct 11 2021, 11:34 PM

Charlie Jolly (charlie) created this revision.

Harbormaster completed remote builds in B17736: Diff 43161.Oct 11 2021, 11:34 PM

Charlie Jolly (charlie) mentioned this in T92103: Geometry Nodes noise does not match Cycles.Oct 11 2021, 11:37 PM

The description should describe what the problem was, how this patch fixes it.
But the bug fix and the new code should be split off, it's generally important to keep the two separate.

This revision now requires changes to proceed.Oct 11 2021, 11:38 PM

Charlie Jolly (charlie) edited the summary of this revision. (Show Details)Oct 11 2021, 11:38 PM

Charlie Jolly (charlie) added a project: Geometry Nodes.

Charlie Jolly (charlie) added a task: T92103: Geometry Nodes noise does not match Cycles.

Charlie Jolly (charlie) added a subscriber: Omar Emara (OmarSquircleArt).