Fix T92149: Missing check for empty components
ClosedPublic
Actions

Authored by Wannes Malfait (Wannes) on Oct 12 2021, 5:10 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T92149: Geometry Nodes: Using Delete Geometry node after Fill Curve node causes a crash

Commits

rB5e3877e0c856: Fix T92149: Crash in delete geometry node after curve fill node

Summary

There was only a check for the component but not for if it was empty.
Because the curve fill node produces an empty curve component, a
nullptr was read, causing a crash.

Diff Detail

Repository

rB Blender

Branch

empty_component_fix (branched from master)

Build Status

Buildable 17761
Build 17761: arc lint + arc unit

Event Timeline

Wannes Malfait (Wannes) requested review of this revision.Oct 12 2021, 5:10 PM

Wannes Malfait (Wannes) created this revision.

Harbormaster completed remote builds in B17761: Diff 43200.Oct 12 2021, 5:10 PM

Wannes Malfait (Wannes) added a task: T92149: Geometry Nodes: Using Delete Geometry node after Fill Curve node causes a crash.Oct 12 2021, 5:11 PM

Wannes Malfait (Wannes) added a reviewer: Hans Goudey (HooglyBoogly).

Wannes Malfait (Wannes) added a project: Geometry Nodes.

Thanks for the fix. Since the new checks also check whether the component exists, the old checks for the component are unnecessary now, so it can just use if (geometry_set.has_mesh()) {, etc.

This revision now requires changes to proceed.Oct 12 2021, 5:29 PM