Fix T92113: On assets, replace "Fake User" button with "Clear Asset" button.
ClosedPublic
Actions

Authored by Bastien Montagne (mont29) on Oct 12 2021, 5:20 PM.

Details

Reviewers

Julian Eisel (Severin)
Sybren A. Stüvel (sybren)

Maniphest Tasks

T92113: On assets, replace "Fake User" button with "Clear Asset" button

Commits

rB59113df8ec3c: Fix T92113: On assets, replace "Fake User" button with "Clear Asset" button.

Summary

Change is simple enough, but we abuse a bit the UI code here to get a
similar 'look' as the fake user button for the new Asset one, while
still being able to call an operator instead of editing directly a RNA
value.

Diff Detail

Repository

rB Blender

Branch

T92113 (branched from master)

Build Status

Buildable 17762
Build 17762: arc lint + arc unit

Event Timeline

Bastien Montagne (mont29) requested review of this revision.Oct 12 2021, 5:20 PM

Bastien Montagne (mont29) created this revision.

Harbormaster completed remote builds in B17762: Diff 43201.Oct 12 2021, 5:20 PM

Bastien Montagne (mont29) added projects: User Interface, BF Blender (3.0), Asset Browser.Oct 12 2021, 5:20 PM

LGTM! I'll leave the final verdict to Julian, as he's in the UI module.

This is quite nice I think. Think the little bit of hackiness in the code is fine, esp since this is a temporary solution until fake user isn't needed anymore (at least not as-is).

Looks like this: