Cleanup: Remove unused code paths in the depsgraph copy-on-write
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Oct 13 2021, 1:00 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Sybren A. Stüvel (sybren)

Commits

rBc29f20a52151: Cleanup: Remove unused code paths in the depsgraph copy-on-write

Summary

Seems to be residue from an early 2.80 days: the placeholder code path
is no longer used.

Remove all the tricky code for this, and make it clear that the
deg_expand_copy_on_write_datablock is used on an non-expanded
datablock.

Should be no functional changes. And should help simplify D12850.

Diff Detail

Repository

rB Blender

Branch

depsgraph_cleanup (branched from master)

Build Status

Buildable 17796
Build 17796: arc lint + arc unit

Event Timeline

Sergey Sharybin (sergey) requested review of this revision.Oct 13 2021, 1:00 PM

Sergey Sharybin (sergey) created this revision.

Harbormaster completed remote builds in B17796: Diff 43244.Oct 13 2021, 1:00 PM

Sergey Sharybin (sergey) mentioned this in D12850: Fix T92136: Leak accessing evaluated depsgraph data from Python.Oct 13 2021, 1:05 PM

Tested D12850 on top of this, and it works well, further this patch seems straightforward.

This revision is now accepted and ready to land.Oct 13 2021, 2:00 PM

Closed by commit rBc29f20a52151: Cleanup: Remove unused code paths in the depsgraph copy-on-write (authored by Sergey Sharybin (sergey)). · Explain WhyOct 13 2021, 3:47 PM

This revision was automatically updated to reflect the committed changes.

Sergey Sharybin (sergey) added a commit: rBc29f20a52151: Cleanup: Remove unused code paths in the depsgraph copy-on-write.

Revision Contents
Changeset List

Path

Size

source/

blender/

depsgraph/

intern/

eval/

deg_eval_copy_on_write.h

12 lines

deg_eval_copy_on_write.cc

66 lines

Diff 43244

View Options

source/blender/depsgraph/intern/eval/deg_eval_copy_on_write.h