warnings for inputs with instances in Geometry Proximity and Sample Curve geometry nodes
ClosedPublic
Actions

Authored by Peter Sergay (psergay) on Oct 13 2021, 5:50 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T91884: Add warnings for nodes that don't work with instances

Commits

rB9959c5315f46: Geometry Nodes: Add warnings for instances input in two nodes

Summary

This addresses T91884: Add warnings for nodes that don't work with instances

Problem: Certain geometry nodes don't work properly on inputs that contain instances, but don't display any warning that they aren't working. For the user, it will just look like the node is doing nothing or not recognizing the inputs.

Solution: The nodes now will display a warning that tells the user to consider adding a Realize Instances node iff the input contains any instances. If the input doesn't contain instances, the warning goes away. This warning has been added to Geometry Proximity and Sample Curve.

warning displays when instances are present

warning goes away

Diff Detail

Repository: rB Blender

Event Timeline

Peter Sergay (psergay) requested review of this revision.Oct 13 2021, 5:50 PM

Peter Sergay (psergay) created this revision.

Peter Sergay (psergay) added a task: T91884: Add warnings for nodes that don't work with instances.

Peter Sergay (psergay) edited the summary of this revision. (Show Details)Oct 13 2021, 6:04 PM

Peter Sergay (psergay) edited the summary of this revision. (Show Details)

Hi Peter, sorry for the delay! I will commit this with a slight change to the wording, to The node only supports realized mesh or point cloud data, instances are ignored
We discussed it in the module meetings here: https://devtalk.blender.org/t/2021-10-04-2021-10-15-geometry-nodes-sub-module-meetings/20971
Generally Blender doesn't use language that's more prescriptive, and we thought it was best to stay consistent. The word "realized" should give people a good hint anyway.

Beyond that, thanks again for the patch!

source/blender/nodes/geometry/nodes/node_geo_proximity.cc
213–215	This white-space change is unnecessary, it's a trivial change (will be solved by auto formatting), so I can adjust this when committing the patch.

This revision is now accepted and ready to land.Oct 20 2021, 6:47 PM

Closed by commit rB9959c5315f46: Geometry Nodes: Add warnings for instances input in two nodes (authored by Peter Sergay (psergay), committed by Hans Goudey (HooglyBoogly)). · Explain WhyOct 20 2021, 6:49 PM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rB9959c5315f46: Geometry Nodes: Add warnings for instances input in two nodes.

Thank you, Hans! I think the new wording you chose is great and more consistent with the language of Blender.

Daniel Houghton (dhoughto) added a subscriber: Daniel Houghton (dhoughto).Oct 22 2021, 4:59 PM