Fix T92184: Cage gizmo doesn't with area light
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Oct 13 2021, 6:46 PM.

Details

Reviewers

Sebastian Parborg (zeddb)
Campbell Barton (campbellbarton)

Maniphest Tasks

T92184: Manipulating area light size with widget is not working

Commits

rB9a3c7da93490: Fix T92184: Cage gizmo doesn't with area light

Summary

This is caused by removing gizmo_cage2d_modal() code in 482806c8167.

Some areas use cage gizmo to modify RNA properties without using
transform operator like area light, image empty, and compositor preview.
This functionality is implemented in code that was removed.

Add this code back.

Diff Detail

Repository: rB Blender

Event Timeline

Richard Antalik (ISS) requested review of this revision.Oct 13 2021, 6:46 PM

Richard Antalik (ISS) created this revision.

Harbormaster completed remote builds in B17807: Diff 43271.Oct 13 2021, 6:46 PM

Campbell Barton (campbellbarton) accepted this revision.Oct 14 2021, 5:36 AM

This revision is now accepted and ready to land.Oct 14 2021, 5:36 AM

Pratik Borhade (PratikPB2123) awarded a token.Oct 14 2021, 6:05 AM

Sebastian Parborg (zeddb) accepted this revision.Oct 14 2021, 11:57 AM

Pratik Borhade (PratikPB2123) mentioned this in T92184: Manipulating area light size with widget is not working.Oct 15 2021, 10:00 AM

Pratik Borhade (PratikPB2123) added a task: T92184: Manipulating area light size with widget is not working.

Closed by commit rB9a3c7da93490: Fix T92184: Cage gizmo doesn't with area light (authored by Richard Antalik (ISS)). · Explain WhyOct 15 2021, 11:21 PM

This revision was automatically updated to reflect the committed changes.

Richard Antalik (ISS) added a commit: rB9a3c7da93490: Fix T92184: Cage gizmo doesn't with area light.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

gizmo_library/

gizmo_types/

cage2d_gizmo.c

219 lines

Diff 43404

View Options

source/blender/editors/gizmo_library/gizmo_types/cage2d_gizmo.c

Fix T92184: Cage gizmo doesn't with area lightClosedPublicActions