Page MenuHome
Differential D12866

Fix T92131: Handle node declaration in material properties.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Oct 14 2021, 5:42 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T92131: Missing some texture input option in yellow color socket node in material properties
Commits
rBaca38148ad56: Fix T92131: handle node declaration in material properties
Summary

The issue was that this menu was only looking at socket templates, but not at the new node declarations.
This fix is to just check those as well. The fix comes with a small refactor that makes the memory management a bit simpler.

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Oct 14 2021, 5:42 PM
Jacques Lucke (JacquesLucke) created this revision.
Harbormaster completed remote builds in B17828: Diff 43306.Oct 14 2021, 5:42 PM
Jacques Lucke (JacquesLucke) added a task: T92131: Missing some texture input option in yellow color socket node in material properties.Oct 14 2021, 5:43 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)
Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).Oct 14 2021, 5:46 PM
Hans Goudey (HooglyBoogly) accepted this revision.Oct 14 2021, 6:51 PM

This looks pretty straightforward, and as always, vector is a huge improvement over a linked list.

This revision is now accepted and ready to land.Oct 14 2021, 6:51 PM
Closed by commit rBaca38148ad56: Fix T92131: handle node declaration in material properties (authored by Jacques Lucke (JacquesLucke)). · Explain WhyOct 15 2021, 12:30 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rBaca38148ad56: Fix T92131: handle node declaration in material properties.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_node/
168 lines

Diff 43366

View Options

source/blender/editors/space_node/node_templates.cc

Loading...