Page MenuHome

Fix T92314: Auto naming of the Vertex Group doesn't work for Grease Pencil
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Oct 18 2021, 4:39 PM.

Details

Summary

Not naming the auto-generated vertexgroup after the selected bone was
just confusing (since the group would not have an effect), so now use
similar code that is used for meshes for greasepencil as well.

Diff Detail

Repository
rB Blender
Branch
T92314 (branched from master)
Build Status
Buildable 17947
Build 17947: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Oct 18 2021, 4:39 PM
Antonio Vazquez (antoniov) requested changes to this revision.Oct 18 2021, 5:03 PM

I have tested with a simple stroke without vertex groups and it crash because the stroke hasn't armatures.

source/blender/editors/gpencil/gpencil_weight_paint.c
270

I have tested and there is a crash. I guess is because if you paint a stroke without any relation with an armature, the if does nothing.

You would need to add:

else  if (gso->object) {
BKE_object_defgroup_add(gso->object);
}´´´
This revision now requires changes to proceed.Oct 18 2021, 5:03 PM

Tested...now works perfect!

LGTM!

This revision is now accepted and ready to land.Oct 18 2021, 6:53 PM