Page MenuHome
Differential D12909

Cycles: avoid intermediate stack array for writing shadow intersections
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Oct 18 2021, 8:13 PM.

Details

Reviewers
William Leeson (leesonw)
Commits
rCa6fe48d1fedf: Avoid intermediate stack array for writing shadow intersections
rBd06828f0b8eb: Cycles: avoid intermediate stack array for writing shadow intersections
Summary

Helps save one OptiX payload and hopefully is more efficient.

Depends on D12889

Diff Detail

Repository
rB Blender

Event Timeline

Brecht Van Lommel (brecht) requested review of this revision.Oct 18 2021, 8:13 PM
Brecht Van Lommel (brecht) created this revision.
Harbormaster completed remote builds in B17954: Diff 43508.Oct 18 2021, 8:13 PM
Brecht Van Lommel (brecht) added a child revision: D12880: Cycles: bake transparent shadows for hair.Oct 18 2021, 8:15 PM
Brecht Van Lommel (brecht) updated this revision to Diff 43513.Oct 18 2021, 8:28 PM

Fix error in OptiX implementation

Harbormaster completed remote builds in B17959: Diff 43513.Oct 18 2021, 8:28 PM
William Leeson (leesonw) accepted this revision.Oct 18 2021, 9:36 PM

Love this :-) It saves a parameter and made me realise I can do something similar for the offset removal :-)

This revision is now accepted and ready to land.Oct 18 2021, 9:36 PM
Brecht Van Lommel (brecht) updated this revision to Diff 43523.Oct 18 2021, 11:39 PM

Fix error with ribbon curves. Visibility always needs to be in payload 4 since the intersection program assumes it.

Harbormaster completed remote builds in B17966: Diff 43523.Oct 18 2021, 11:39 PM
Closed by commit rBd06828f0b8eb: Cycles: avoid intermediate stack array for writing shadow intersections (authored by Brecht Van Lommel (brecht)). · Explain WhyOct 19 2021, 3:30 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rBd06828f0b8eb: Cycles: avoid intermediate stack array for writing shadow intersections.
Brecht Van Lommel (brecht) added a commit: rCa6fe48d1fedf: Avoid intermediate stack array for writing shadow intersections.Jan 27 2022, 11:30 PM

Revision Contents
Changeset List

PathSize
intern/
cycles/
kernel/
bvh/
19 lines
15 lines
29 lines
device/
optix/
22 lines
integrator/
56 lines

Diff 43577

View Options

intern/cycles/kernel/bvh/bvh.h

Loading...
View Options

intern/cycles/kernel/bvh/bvh_shadow_all.h

Loading...
View Options

intern/cycles/kernel/bvh/bvh_util.h

Loading...
View Options

intern/cycles/kernel/device/optix/kernel.cu

Loading...
View Options

intern/cycles/kernel/integrator/integrator_intersect_shadow.h

Loading...