Paths

Table of Contentst

Differential D12913

Cleanup: split 'transform_gizmo_3d.c' in specific compilation units
Needs ReviewPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Oct 19 2021, 2:18 AM.

Details

Reviewers

Campbell Barton (campbellbarton)

Summary

transform_gizmo_3ds is already big and will get bigger when new
transform gizmos are implemented.

So while this might miss some build optimizations, it will have long-
term benefits.

Diff Detail

Repository

rB Blender

Branch

transform-cleanup (branched from master)

Build Status

Buildable 18020
Build 18020: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) requested review of this revision.Oct 19 2021, 2:18 AM

Germano Cavalcante (mano-wii) created this revision.

Harbormaster completed remote builds in B17975: Diff 43535.Oct 19 2021, 2:18 AM

Campbell Barton (campbellbarton) added inline comments.Oct 19 2021, 2:25 AM

source/blender/editors/transform/transform_gizmo.h
1 ↗	(On Diff #43535)	Prefer name `transform_gizmo_3d.h` (we may have a 2D version later). Same for `transform_gizmo.c`.
43–90 ↗	(On Diff #43535)	Can't this be kept private?

Rename transform_gizmo to transform_gizmo_3d
Move drawDial3d to transform_gizmo_3d_loc_rot_scale.c to keep some variables private

Harbormaster completed remote builds in B18020: Diff 43603.Oct 19 2021, 10:04 PM

Germano Cavalcante (mano-wii) marked 2 inline comments as done.Oct 19 2021, 10:04 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

transform/

6 lines

4 lines

1 line

2 lines

70 lines

1720 lines

transform_gizmo_3d_cage.c

255 lines

	transform_gizmo_3d_extrude.c
	transform_gizmo_extrude_3d.c

537 lines

transform_gizmo_3d_loc_rot_scale.c

1161 lines

transform_gizmo_3d_shear.c

290 lines

transform_gizmo_extrude_3d.c

transform_orientations.c

111 lines

Diff 43603

View Options

source/blender/editors/transform/CMakeLists.txt

View Options

source/blender/editors/transform/transform.h

View Options

source/blender/editors/transform/transform.c

View Options

source/blender/editors/transform/transform_gizmo_2d.c

View Options

source/blender/editors/transform/transform_gizmo_3d.h

View Options

source/blender/editors/transform/transform_gizmo_3d.c

View Options

source/blender/editors/transform/transform_gizmo_3d_cage.c

View Options

source/blender/editors/transform/transform_gizmo_3d_extrude.c

View Options

source/blender/editors/transform/transform_gizmo_3d_loc_rot_scale.c

View Options

source/blender/editors/transform/transform_gizmo_3d_shear.c

View Options

source/blender/editors/transform/transform_gizmo_extrude_3d.c

View Options

source/blender/editors/transform/transform_orientations.c

Cleanup: split 'transform_gizmo_3d.c' in specific compilation unitsNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43603

source/blender/editors/transform/CMakeLists.txt

source/blender/editors/transform/transform.h

source/blender/editors/transform/transform.c

source/blender/editors/transform/transform_gizmo_2d.c

source/blender/editors/transform/transform_gizmo_3d.h

source/blender/editors/transform/transform_gizmo_3d.c

source/blender/editors/transform/transform_gizmo_3d_cage.c

source/blender/editors/transform/transform_gizmo_3d_extrude.c

source/blender/editors/transform/transform_gizmo_3d_loc_rot_scale.c

source/blender/editors/transform/transform_gizmo_3d_shear.c

source/blender/editors/transform/transform_gizmo_extrude_3d.c

source/blender/editors/transform/transform_orientations.c

Cleanup: split 'transform_gizmo_3d.c' in specific compilation units
Needs ReviewPublic
Actions

Revision Contents
Changeset List